qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jes.Sorensen@redhat.com,
	Alex Williamson <alex.williamson@redhat.com>,
	qemu-devel@nongnu.org, agraf@suse.de
Subject: [Qemu-devel] Re: [PATCH] e1000: multi-buffer packet support
Date: Thu, 3 Feb 2011 16:38:44 +0000	[thread overview]
Message-ID: <20110203163844.GA31906@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <20110203153835.GA28388@redhat.com>

On Thu, Feb 03, 2011 at 05:38:35PM +0200, Michael S. Tsirkin wrote:
> @@ -654,7 +656,7 @@ e1000_receive(VLANClientState *nc, const uint8_t *buf, size_t size)
>          size = sizeof(min_buf);
>      }
> 
> -    if (size > s->rxbuf_size) {
> +    if (0 && size > s->rxbuf_size) {
>          DBGOUT(RX, "packet too large for buffers (%lu > %d)\n",
>                 (unsigned long)size, s->rxbuf_size);
>          return -1;

Please remove completely or enhance this conditional to work in a
multi-buffer world.

Stefan

      parent reply	other threads:[~2011-02-03 16:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-03 15:38 [Qemu-devel] [PATCH] e1000: multi-buffer packet support Michael S. Tsirkin
2011-02-03 16:36 ` [Qemu-devel] " Alex Williamson
2011-02-03 16:45   ` Michael S. Tsirkin
2011-02-03 16:38 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110203163844.GA31906@stefanha-thinkpad.localdomain \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=Jes.Sorensen@redhat.com \
    --cc=agraf@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).