From: Amit Shah <amit.shah@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu list <qemu-devel@nongnu.org>, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH master/0.14] virtio-serial: Make sure virtqueue is ready before discarding data
Date: Tue, 8 Feb 2011 13:25:58 +0530 [thread overview]
Message-ID: <20110208075558.GD29281@amit-x200.redhat.com> (raw)
In-Reply-To: <4D50F359.7070002@codemonkey.ws>
On (Tue) 08 Feb 2011 [01:40:09], Anthony Liguori wrote:
> >
> >However, virtio doesn't have vmstate yet. Are we willing to put vmstate
> >in 0.14 to introduce subsections? I doubt that.
>
> Not, that's why I suggested reverting this change and pushing it to
> 0.15. We're not going to fix it properly in 0.14.
You mean reverting all of the flow control work? But then it exposes
another bug: a malicious guest doing huge writes will cause an OOM on
the host; it's better to have this fix rather than not have it.
Amit
prev parent reply other threads:[~2011-02-08 7:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 8:54 [Qemu-devel] [PATCH master/0.14] virtio-serial: Make sure virtqueue is ready before discarding data Amit Shah
2011-02-04 12:11 ` [Qemu-devel] " Juan Quintela
2011-02-04 12:52 ` [Qemu-devel] " Anthony Liguori
2011-02-06 6:20 ` Amit Shah
2011-02-08 2:14 ` Amit Shah
2011-02-08 2:25 ` Anthony Liguori
2011-02-08 2:55 ` Amit Shah
2011-02-08 7:40 ` Anthony Liguori
2011-02-08 7:55 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110208075558.GD29281@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).