From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58201 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PmiQe-0005Kl-7o for qemu-devel@nongnu.org; Tue, 08 Feb 2011 02:56:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PmiQd-0005Qw-GO for qemu-devel@nongnu.org; Tue, 08 Feb 2011 02:56:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PmiQd-0005Qr-8Y for qemu-devel@nongnu.org; Tue, 08 Feb 2011 02:56:03 -0500 Date: Tue, 8 Feb 2011 13:25:58 +0530 From: Amit Shah Subject: Re: [Qemu-devel] [PATCH master/0.14] virtio-serial: Make sure virtqueue is ready before discarding data Message-ID: <20110208075558.GD29281@amit-x200.redhat.com> References: <4D4BF674.5050305@codemonkey.ws> <20110206062046.GA1234@amit-x200.redhat.com> <20110208021422.GA691@amit-x200.redhat.com> <4D50A9B7.7040004@codemonkey.ws> <20110208025513.GE32178@amit-x200.redhat.com> <4D50F359.7070002@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D50F359.7070002@codemonkey.ws> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu list , Juan Quintela On (Tue) 08 Feb 2011 [01:40:09], Anthony Liguori wrote: > > > >However, virtio doesn't have vmstate yet. Are we willing to put vmstate > >in 0.14 to introduce subsections? I doubt that. > > Not, that's why I suggested reverting this change and pushing it to > 0.15. We're not going to fix it properly in 0.14. You mean reverting all of the flow control work? But then it exposes another bug: a malicious guest doing huge writes will cause an OOM on the host; it's better to have this fix rather than not have it. Amit