From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52231 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PmxxS-0002A1-Lb
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 19:31:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1PmxxP-0002aw-Fy
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 19:30:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47690)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1PmxxP-0002ag-8h
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 19:30:55 -0500
Date: Tue, 8 Feb 2011 21:39:03 -0200
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20110208233903.GA16795@amt.cnet>
References: <cover.1297077506.git.jan.kiszka@siemens.com>
	<149ef70e3a2ebe96529b0956da4bd4009099e3ac.1297077507.git.jan.kiszka@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <149ef70e3a2ebe96529b0956da4bd4009099e3ac.1297077507.git.jan.kiszka@siemens.com>
Subject: [Qemu-devel] Re: [PATCH 07/15] kvm: Separate TCG from KVM cpu
	execution
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org

On Mon, Feb 07, 2011 at 12:19:18PM +0100, Jan Kiszka wrote:
> Mixing up TCG bits with KVM already led to problems around eflags
> emulation on x86. Moreover, quite some code that TCG requires on cpu
> enty/exit is useless for KVM. So dispatch between tcg_cpu_exec and
> kvm_cpu_exec as early as possible.
> 
> The core logic of cpu_halted from cpu_exec is added to
> kvm_arch_process_irqchip_events. Moving away from cpu_exec makes
> exception_index meaningless for KVM, we can simply pass the exit reason
> directly (only "EXCP_DEBUG vs. rest" is relevant).
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  cpu-exec.c        |   19 ++++++-------------
>  cpus.c            |   10 +++++-----
>  kvm-all.c         |   19 +++++++++----------
>  target-i386/kvm.c |    6 +++---
>  4 files changed, 23 insertions(+), 31 deletions(-)
> 
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index ba183c4..377a0a3 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -1502,12 +1502,13 @@ int kvm_arch_post_run(CPUState *env, struct kvm_run *run)
>  
>  int kvm_arch_process_irqchip_events(CPUState *env)
>  {
> +    if (env->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI)) {
> +        env->halted = 0;
> +    }

Why is it necessary to clear env->halted here?