From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60676 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pn7Et-0002GE-Fq for qemu-devel@nongnu.org; Wed, 09 Feb 2011 05:25:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pn7Er-0005Ek-V5 for qemu-devel@nongnu.org; Wed, 09 Feb 2011 05:25:35 -0500 Received: from afflict.kos.to ([92.243.29.197]:33194) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pn7Er-0005EP-La for qemu-devel@nongnu.org; Wed, 09 Feb 2011 05:25:33 -0500 Date: Wed, 9 Feb 2011 12:25:32 +0200 From: Riku Voipio Subject: Re: [Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes) Message-ID: <20110209102532.GA29059@afflict.kos.to> References: <2254887.338399.1297243238443.JavaMail.servlet@pustefix155.kundenserver.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2254887.338399.1297243238443.JavaMail.servlet@pustefix155.kundenserver.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: aliguori@us.ibm.com, riku.voipio@iki.fi, qemu-devel@nongnu.org > >Actually that patch is not ok. The issues you fix on m68k appear > >on arm/eabi after applying your patch. bswap part appears ok, but > >the padding is needed atleast on arm. > How do you test this patch ? Do you use native gdb on ARM ? Because, for m68k, cross-compiled gdb does not work (it cannot have sizeof(prstatus_t) for m68k). I tried both native and cross-gdb, version 7.2. Both fail with your patch applied and work fine without it. Before your patch, objdump (CodeSourcery cs2009q3 cross) output looks like: -snip- Sections: Idx Name Size VMA LMA File off Algn 0 note0 000001bc 00000000 00000000 000000d4 2**0 CONTENTS, READONLY 1 .reg/23968 00000048 00000000 00000000 00000130 2**2 CONTENTS 2 .reg 00000048 00000000 00000000 00000130 2**2 CONTENTS 3 .auxv 00000070 00000000 00000000 00000220 2**2 CONTENTS 4 load1 00000000 00008000 00000000 00001000 2**12 ALLOC, READONLY, CODE -snip- after: -snip- Sections: Idx Name Size VMA LMA File off Algn 0 note0 000001bc 00000000 00000000 000000d4 2**0 CONTENTS, READONLY 1 .auxv 00000070 00000000 00000000 00000220 2**2 CONTENTS 2 load1 00000000 00008000 00000000 00001000 2**12 ALLOC, READONLY, CODE CONTENTS, ALLOC, LOAD -snip-