From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49328 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PnVKV-0001Pi-Cd for qemu-devel@nongnu.org; Thu, 10 Feb 2011 07:09:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PnVKH-0000Ou-Py for qemu-devel@nongnu.org; Thu, 10 Feb 2011 07:08:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59348) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PnVKH-0000Oh-In for qemu-devel@nongnu.org; Thu, 10 Feb 2011 07:08:45 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1AC8itt021204 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 10 Feb 2011 07:08:44 -0500 Date: Thu, 10 Feb 2011 17:38:37 +0530 From: Amit Shah Subject: Re: [Qemu-devel] [PATCH 1/2] qdev: Allow hot-plug for lists with pre-filled descriptors Message-ID: <20110210120837.GF12598@amit-x200.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Luiz Capitulino , qemu list , Gerd Hoffmann On (Thu) 10 Feb 2011 [12:57:30], Markus Armbruster wrote: > Amit Shah writes: > > > This will be needed for hot-plugging chardevs. > > > > Signed-off-by: Amit Shah > > --- > > monitor.c | 4 +--- > > 1 files changed, 1 insertions(+), 3 deletions(-) > > > > diff --git a/monitor.c b/monitor.c > > index 7fc311d..f3d7ab3 100644 > > --- a/monitor.c > > +++ b/monitor.c > > @@ -74,8 +74,6 @@ > > * 'O' option string of the form NAME=VALUE,... > > * parsed according to QemuOptsList given by its name > > * Example: 'device:O' uses qemu_device_opts. > > - * Restriction: only lists with empty desc are supported > > - * TODO lift the restriction > > * 'i' 32 bit integer > > * 'l' target long (32 or 64 bit) > > * 'M' just like 'l', except in user mode the value is > > @@ -4064,7 +4062,7 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon, > > QemuOpts *opts; > > > > opts_list = qemu_find_opts(key); > > - if (!opts_list || opts_list->desc->name) { > > + if (!opts_list) { > > goto bad_type; > > } > > while (qemu_isspace(*p)) { > > Uh, there's more to do that just kill the check (that's why I put in the > TODO in the first place), I thought so :-) This did work for me for a few runs, and I really haven't traversed the depths of qdev so sent it out anyway for comment. > but my virus-addled brain can't quite remember > the details right now :( Wish you a speedy recovery in the meantime! Amit