From: Michael Walle <michael@walle.cc>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Richard Henderson <rth@twiddle.net>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 11/17] lm32: system control model
Date: Fri, 11 Feb 2011 23:35:10 +0100 [thread overview]
Message-ID: <201102112335.10845.michael@walle.cc> (raw)
In-Reply-To: <AANLkTinwUMr5OrjDqCFjQJ=RMFFp+h6v0nGgDZA69SX0@mail.gmail.com>
Am Freitag 11 Februar 2011, 22:03:40 schrieb Blue Swirl:
> > +static int lm32_sys_init(SysBusDevice *dev)
> > +{
> > + LM32SysState *s = FROM_SYSBUS(typeof(*s), dev);
> > + int sys_regs;
> > +
> > + sys_regs = cpu_register_io_memory(sys_read_fn, sys_write_fn, s,
> > + DEVICE_NATIVE_ENDIAN);
> > + sysbus_init_mmio(dev, R_MAX * 4, sys_regs);
> > + sysbus_mmio_map(dev, 0, s->base);
>
> Devices should not map themselves or care what is their address.
> Please remove base field and qdev property and move the mapping to
> board level.
I added this because the device isn't created in the board initialization.
Instead it can be added with -device, if needed. Who does the mapping in this
case?
--
Michael
next prev parent reply other threads:[~2011-02-11 22:35 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 23:11 [Qemu-devel] [PATCH 00/17 v2] LatticeMico32 target Michael Walle
2011-02-10 23:11 ` [Qemu-devel] [PATCH 01/17] LatticeMico32 target support Michael Walle
2011-02-10 23:11 ` [Qemu-devel] [PATCH 02/17] lm32: translation routines Michael Walle
2011-02-11 21:42 ` Blue Swirl
2011-02-11 22:23 ` Michael Walle
2011-02-12 6:49 ` Blue Swirl
2011-02-17 22:51 ` Michael Walle
2011-03-11 5:57 ` Alexander Graf
2011-03-16 23:08 ` Michael Walle
2011-03-16 23:48 ` Alexander Graf
2011-02-12 13:18 ` Michael Walle
2011-02-10 23:11 ` [Qemu-devel] [PATCH 03/17] lm32: translation code helper Michael Walle
2011-02-10 23:11 ` [Qemu-devel] [PATCH 04/17] lm32: machine state loading/saving Michael Walle
2011-02-10 23:11 ` [Qemu-devel] [PATCH 05/17] lm32: gdbstub support Michael Walle
2011-02-10 23:11 ` [Qemu-devel] [PATCH 06/17] lm32: interrupt controller model Michael Walle
2011-02-11 21:49 ` Blue Swirl
2011-02-10 23:12 ` [Qemu-devel] [PATCH 07/17] lm32: juart model Michael Walle
2011-02-11 21:09 ` Blue Swirl
2011-02-10 23:12 ` [Qemu-devel] [PATCH 08/17] lm32: pic and juart helper functions Michael Walle
2011-02-11 20:57 ` Blue Swirl
2011-02-10 23:12 ` [Qemu-devel] [PATCH 09/17] lm32: timer model Michael Walle
2011-02-11 21:22 ` Blue Swirl
2011-02-11 22:29 ` Michael Walle
2011-02-12 6:56 ` Blue Swirl
2011-02-10 23:12 ` [Qemu-devel] [PATCH 10/17] lm32: uart model Michael Walle
2011-02-11 21:16 ` Blue Swirl
2011-02-10 23:12 ` [Qemu-devel] [PATCH 11/17] lm32: system control model Michael Walle
2011-02-11 21:03 ` Blue Swirl
2011-02-11 22:35 ` Michael Walle [this message]
2011-02-12 7:54 ` Blue Swirl
2011-02-10 23:12 ` [Qemu-devel] [PATCH 12/17] lm32: support for creating device tree Michael Walle
2011-02-11 20:52 ` Blue Swirl
2011-02-11 22:40 ` Michael Walle
2011-02-12 7:56 ` Blue Swirl
2011-02-10 23:12 ` [Qemu-devel] [PATCH 13/17] lm32: EVR32 and uclinux BSP Michael Walle
2011-02-11 20:47 ` Blue Swirl
2011-02-10 23:12 ` [Qemu-devel] [PATCH 14/17] lm32: todo and documentation Michael Walle
2011-02-11 20:41 ` Blue Swirl
2011-02-11 22:45 ` Michael Walle
2011-02-12 8:00 ` Blue Swirl
2011-02-10 23:12 ` [Qemu-devel] [PATCH 15/17] lm32: opcode testsuite Michael Walle
2011-02-10 23:12 ` [Qemu-devel] [PATCH 16/17] Add lm32 target to configure Michael Walle
2011-02-10 23:12 ` [Qemu-devel] [PATCH 17/17] MAINTAINERS: add LatticeMico32 maintainer Michael Walle
2011-02-11 9:48 ` [Qemu-devel] Re: [PATCH 00/17 v2] LatticeMico32 target Edgar E. Iglesias
-- strict thread matches above, loose matches on Subject: below --
2011-02-17 22:45 [Qemu-devel] [PATCH 00/17 v3] " Michael Walle
2011-02-17 22:45 ` [Qemu-devel] [PATCH 11/17] lm32: system control model Michael Walle
2011-01-31 0:30 [Qemu-devel] [PATCH 00/17] LatticeMico32 target Michael Walle
2011-01-31 0:30 ` [Qemu-devel] [PATCH 11/17] lm32: system control model Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102112335.10845.michael@walle.cc \
--to=michael@walle.cc \
--cc=agraf@suse.de \
--cc=blauwirbel@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).