From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57646 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PoaK0-0000Nb-BD for qemu-devel@nongnu.org; Sun, 13 Feb 2011 06:40:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PoaJy-00029q-SO for qemu-devel@nongnu.org; Sun, 13 Feb 2011 06:40:56 -0500 Received: from ozlabs.org ([203.10.76.45]:38299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PoaJy-00029Y-ES for qemu-devel@nongnu.org; Sun, 13 Feb 2011 06:40:54 -0500 Date: Sun, 13 Feb 2011 22:14:50 +1100 From: David Gibson Subject: Re: [Qemu-devel] Re: [PATCH 15/15] Implement the bus structure for PAPR virtual IO Message-ID: <20110213111450.GD18294@yookeroo> References: <1297522467-5975-1-git-send-email-david@gibson.dropbear.id.au> <1297522467-5975-16-git-send-email-david@gibson.dropbear.id.au> <1BA55C28-0AAF-46A5-A14F-04B0B61419DB@suse.de> <1297544424.14982.628.camel@pasglop> <1297552503.14982.637.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1297552503.14982.637.camel@pasglop> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: Blue Swirl , Paul Mackerras , "qemu-devel@nongnu.org List" , anton@samba.org, Alexander Graf On Sun, Feb 13, 2011 at 10:15:03AM +1100, Benjamin Herrenschmidt wrote: > On Sun, 2011-02-13 at 00:52 +0200, Blue Swirl wrote: > > On Sat, Feb 12, 2011 at 11:00 PM, Benjamin Herrenschmidt [snip] > Actually, one thing I noticed is that the current patches David posted > still have a single function with a switch/case statement for hcalls. > > I'm not 100% certain what David long term plans are here, but in our > internal "WIP" tree, we've subsequently turned that into a mechanism > where any module can call powerpc_register_hypercall() to add hcalls. > > So if David intends to move the "upstream candidate" tree in that > direction, then naturally, the calls in spapr_hcall.c are going to > disappear in favor of a pair of powerpc_register_hypercall() locally in > the vty module. Ah, yeah. I'm still not sure what to do about it. I was going to fold the dynamic hcall registration into the patch set before upstreaming. But then something paulus said made me rethink whether the dynamic registration was a good idea. Still need to sort this out before the series is really ready. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson