From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=32911 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Poc9i-0006La-Mo for qemu-devel@nongnu.org; Sun, 13 Feb 2011 08:38:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Poc9g-0008WC-8P for qemu-devel@nongnu.org; Sun, 13 Feb 2011 08:38:27 -0500 Received: from ozlabs.org ([203.10.76.45]:58581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Poc9f-0008Vp-Pt for qemu-devel@nongnu.org; Sun, 13 Feb 2011 08:38:24 -0500 Date: Sun, 13 Feb 2011 23:52:01 +1100 From: David Gibson Subject: Re: [Qemu-devel] Re: [PATCH 09/15] Parse SDR1 on mtspr instead of at translate time Message-ID: <20110213125201.GH18294@yookeroo> References: <1297522467-5975-1-git-send-email-david@gibson.dropbear.id.au> <1297522467-5975-10-git-send-email-david@gibson.dropbear.id.au> <7A49D0D0-E8F0-469C-89A7-9E2CE64B924B@suse.de> <20110213090231.GA17099@yookeroo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: paulus@samba.org, qemu-devel@nongnu.org, anton@samba.org On Sun, Feb 13, 2011 at 01:33:44PM +0100, Alexander Graf wrote: > > On 13.02.2011, at 10:02, David Gibson wrote: > > > On Sat, Feb 12, 2011 at 04:37:46PM +0100, Alexander Graf wrote: > >> On 12.02.2011, at 15:54, David Gibson wrote: > > [snip] > >>> +#define SDR_HTABORG_32 0xFFFF0000UL > >>> +#define SDR_HTABMASK 0x000001FFUL > >> > >> Please mark this constant as ppc32 > >> > >>> + > >>> +#if defined(TARGET_PPC64) > >>> +#define SDR_HTABORG_64 0xFFFFFFFFFFFC0000ULL > >>> +#define SDR_HTABSIZE 0x000000000000001FULL > >> > >> Please mark this constant as ppc64 > > > > Um.. I'm not sure what you mean by this. > > Well, while to you SDR_HTABMASK and SDR_HTABSIZE are "obviously" > meant for ppc32/ppc64 respectively, the average code reader won't > know the difference. What I'm proposing is: > > #define SDR_32_HTABORG > #define SDR_32_HTABMASK > > #define SDR_64_HTABORG > #define SDR_64_HTABSIZE > > This way it's a lot more obvious that the two constants really > belong to two completely different semantics :). Ah! I see. Done, I'll have this in the next cut. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson