From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56936 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Polsq-000874-Gx for qemu-devel@nongnu.org; Sun, 13 Feb 2011 19:01:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Polsp-0007fV-6a for qemu-devel@nongnu.org; Sun, 13 Feb 2011 19:01:40 -0500 Received: from ozlabs.org ([203.10.76.45]:47079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Polso-0007eq-P5 for qemu-devel@nongnu.org; Sun, 13 Feb 2011 19:01:39 -0500 Date: Mon, 14 Feb 2011 10:33:26 +1100 From: David Gibson Subject: Re: [Qemu-devel] Re: [PATCH 15/15] Implement the bus structure for PAPR virtual IO Message-ID: <20110213233326.GB2821@yookeroo> References: <1297522467-5975-16-git-send-email-david@gibson.dropbear.id.au> <1BA55C28-0AAF-46A5-A14F-04B0B61419DB@suse.de> <1297544424.14982.628.camel@pasglop> <1297552503.14982.637.camel@pasglop> <20110213111245.GC18294@yookeroo> <4D57F3E6.10504@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Alexander Graf , Paul Mackerras , "qemu-devel@nongnu.org List" , anton@samba.org On Sun, Feb 13, 2011 at 08:29:05PM +0200, Blue Swirl wrote: > On Sun, Feb 13, 2011 at 5:08 PM, Anthony Liguori wrote: > > On 02/13/2011 05:12 AM, David Gibson wrote: [snip] > > The arguments will have to be extracted from the CPU state but I don't think > > we'll really ever have common hypercall implementations anyway so that's not > > a huge problem. > > Nice idea. Then the part handling CPUState probably should belong to > target-ppc/ rather than hw/. Doesn't work. Different hypervisors may have arguments - even the hcall number itself - arranged differently in the registers. My earlier drafts had this in target-ppc/; I moved it to hw/ for a reason. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson