qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Alexander Graf <agraf@suse.de>
Cc: Tristan Gingold <gingold@adacore.com>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] Re: Ping: [PATCH] Handle icount for powerpc tbl/tbu/decr load and store.
Date: Mon, 14 Feb 2011 12:46:21 +0100	[thread overview]
Message-ID: <20110214114621.GA8938@edde.se.axis.com> (raw)
In-Reply-To: <4D59132D.7080205@suse.de>

On Mon, Feb 14, 2011 at 12:34:05PM +0100, Alexander Graf wrote:
> Tristan Gingold wrote:
> > Potential reviewers CC:
> >
> > On Feb 8, 2011, at 10:59 AM, Tristan Gingold wrote:
> >
> >   
> >> Handle option '-icount X' on powerpc targets.
> >>
> >> Signed-off-by: Tristan Gingold <gingold@adacore.com>
> >>     
> 
> Braces are broken. Edgar knows his way around icount a lot better than
> me - I've never actually used it. Edgar, any comments?

AFAICS, the patch looks OK (except for the indentation).

Cheers

  reply	other threads:[~2011-02-14 11:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08  9:59 [Qemu-devel] [PATCH] Handle icount for powerpc tbl/tbu/decr load and store Tristan Gingold
2011-02-14 10:07 ` [Qemu-devel] Ping: " Tristan Gingold
2011-02-14 11:34   ` [Qemu-devel] " Alexander Graf
2011-02-14 11:46     ` Edgar E. Iglesias [this message]
2011-02-14 11:55       ` Tristan Gingold
2011-02-15  8:39     ` [Qemu-devel] [PATCHv2] " Tristan Gingold
2011-02-16 14:43       ` [Qemu-devel] " Edgar E. Iglesias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110214114621.GA8938@edde.se.axis.com \
    --to=edgar.iglesias@gmail.com \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=gingold@adacore.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).