From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39924 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pp8AX-0001Ro-QP
	for qemu-devel@nongnu.org; Mon, 14 Feb 2011 18:49:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <scottwood@freescale.com>) id 1Pp8AW-0004DB-MO
	for qemu-devel@nongnu.org; Mon, 14 Feb 2011 18:49:25 -0500
Received: from ch1outboundpool.messaging.microsoft.com ([216.32.181.181]:22599)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <scottwood@freescale.com>) id 1Pp8AW-0004D3-Ep
	for qemu-devel@nongnu.org; Mon, 14 Feb 2011 18:49:24 -0500
Date: Mon, 14 Feb 2011 17:49:04 -0600
From: Scott Wood <scottwood@freescale.com>
Message-ID: <20110214174904.33d3159b@schlenkerla.am.freescale.net>
In-Reply-To: <32AC591D-A27F-4D76-82D4-CB93D66D71E1@suse.de>
References: <9F6FE96B71CF29479FF1CDC8046E15030BCD40@039-SN1MPN1-002.039d.mgd.msft.net>
	<20110202160821.5a223366@udp111988uds>
	<B1B59802-0A65-4F35-B3DD-CB10F44AF86D@suse.de>
	<20110204163338.54690220@udp111988uds>
	<30BEE027-929B-43E5-A638-A58389F90B6F@suse.de>
	<20110207141547.58e49caa@udp111988uds>
	<220F22AA-31E5-4ACB-B0D5-557010096B91@suse.de>
	<20110209170928.6c629514@udp111988uds> <4D53CFE2.6080008@suse.de>
	<20110210125112.6d1f0380@udp111988uds>
	<8ACEDFEA-AA7F-400F-88F1-5F99864E8AAF@suse.de>
	<63E8AA2B-685F-4360-9BC8-E760A2CAD570@suse.de>
	<49812881-9E7C-4295-B708-CFA986EE9500@suse.de>
	<20110211145340.70c5812b@udp111988uds>
	<113B6114-C44E-4DD4-B318-4CAC826179DE@suse.de>
	<20110211185734.42f7f73f@udp111988uds>
	<4DC23D10-A9C9-4C11-A344-A9779C370296@suse.de>
	<20110214111153.07f884b6@udp111988uds>
	<F7188541-9C17-478D-B46F-3FBA4415F6F4@suse.de>
	<20110214151657.0ce8c4a4@schlenkerla.am.freescale.net>
	<32AC591D-A27F-4D76-82D4-CB93D66D71E1@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Yoder Stuart-B08248 <B08248@freescale.com>, "kvm@vger.kernel.org list" <kvm@vger.kernel.org>, "<kvm-ppc@vger.kernel.org>" <kvm-ppc@vger.kernel.org>, "qemu-devel@nongnu.org List" <qemu-devel@nongnu.org>

On Tue, 15 Feb 2011 00:39:51 +0100
Alexander Graf <agraf@suse.de> wrote:

> On 14.02.2011, at 22:16, Scott Wood wrote:
> 
> > On Mon, 14 Feb 2011 21:19:19 +0100
> > Alexander Graf <agraf@suse.de> wrote:
> >>>> The struct name should also have
> >>>> a version indicator - it's the data descriptor only a single specific
> >>>> mmu_type, right?
> >>> 
> >>> It handles both KVM_MMU_PPC_BOOK3E_NOHV and KVM_MMU_PPC_BOOK3E_HV.
> >> 
> >> Even fictional future changes to the tlb layout?
> > 
> > No, those need a new MMU type ID.
> 
> ... which means they need a new name, but then booke_tlb_entry is taken.

The MMU ID name and struct name are about equally generic.  I'll add FSL to
both.  If there's a v2 down the road, then that goes in both.

> > Which one, "read the MMU config registers" or "specify 4K and stick FSL in
> > the name"?
> 
> The "specify 4k and stick fsl in the name" part.

OK.

-Scott