* [Qemu-devel] [PATCH 2/3] target-arm: Fix soft interrupt in GIC distributor
@ 2011-02-15 10:49 Adam Lackorzynski
2011-02-16 13:50 ` Peter Maydell
2011-02-21 20:25 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Adam Lackorzynski @ 2011-02-15 10:49 UTC (permalink / raw)
To: qemu-devel
Fix selection of target list filter mode.
Signed-off-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
---
hw/arm_gic.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/arm_gic.c b/hw/arm_gic.c
index e6b1953..0e934ec 100644
--- a/hw/arm_gic.c
+++ b/hw/arm_gic.c
@@ -549,10 +549,10 @@ static void gic_dist_writel(void *opaque, target_phys_addr_t offset,
mask = (value >> 16) & ALL_CPU_MASK;
break;
case 1:
- mask = 1 << cpu;
+ mask = ALL_CPU_MASK ^ (1 << cpu);
break;
case 2:
- mask = ALL_CPU_MASK ^ (1 << cpu);
+ mask = 1 << cpu;
break;
default:
DPRINTF("Bad Soft Int target filter\n");
--
1.7.2.3
Adam
--
Adam adam@os.inf.tu-dresden.de
Lackorzynski http://os.inf.tu-dresden.de/~adam/
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH 2/3] target-arm: Fix soft interrupt in GIC distributor
2011-02-15 10:49 [Qemu-devel] [PATCH 2/3] target-arm: Fix soft interrupt in GIC distributor Adam Lackorzynski
@ 2011-02-16 13:50 ` Peter Maydell
2011-02-21 20:25 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2011-02-16 13:50 UTC (permalink / raw)
To: Adam Lackorzynski; +Cc: qemu-devel
On 15 February 2011 10:49, Adam Lackorzynski <adam@os.inf.tu-dresden.de> wrote:
> Fix selection of target list filter mode.
>
> Signed-off-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
> ---
> hw/arm_gic.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm_gic.c b/hw/arm_gic.c
> index e6b1953..0e934ec 100644
> --- a/hw/arm_gic.c
> +++ b/hw/arm_gic.c
> @@ -549,10 +549,10 @@ static void gic_dist_writel(void *opaque, target_phys_addr_t offset,
> mask = (value >> 16) & ALL_CPU_MASK;
> break;
> case 1:
> - mask = 1 << cpu;
> + mask = ALL_CPU_MASK ^ (1 << cpu);
> break;
> case 2:
> - mask = ALL_CPU_MASK ^ (1 << cpu);
> + mask = 1 << cpu;
> break;
> default:
> DPRINTF("Bad Soft Int target filter\n");
This looks like a good fix based on the TRM; however I don't have an
A9-based image to hand to test with so I've asked a colleague to give
it a quick smoke test before I formally mark it as reviewed-by me
(probably some time next week).
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH 2/3] target-arm: Fix soft interrupt in GIC distributor
2011-02-15 10:49 [Qemu-devel] [PATCH 2/3] target-arm: Fix soft interrupt in GIC distributor Adam Lackorzynski
2011-02-16 13:50 ` Peter Maydell
@ 2011-02-21 20:25 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2011-02-21 20:25 UTC (permalink / raw)
To: Adam Lackorzynski; +Cc: qemu-devel
On 15 February 2011 10:49, Adam Lackorzynski <adam@os.inf.tu-dresden.de> wrote:
> Fix selection of target list filter mode.
>
> Signed-off-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-21 20:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-15 10:49 [Qemu-devel] [PATCH 2/3] target-arm: Fix soft interrupt in GIC distributor Adam Lackorzynski
2011-02-16 13:50 ` Peter Maydell
2011-02-21 20:25 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).