From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=60156 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ppfhu-0002II-5l
	for qemu-devel@nongnu.org; Wed, 16 Feb 2011 06:38:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1Ppfhs-0000MS-SE
	for qemu-devel@nongnu.org; Wed, 16 Feb 2011 06:38:05 -0500
Received: from mtagate1.uk.ibm.com ([194.196.100.161]:48699)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1Ppfhs-0000Lr-Go
	for qemu-devel@nongnu.org; Wed, 16 Feb 2011 06:38:04 -0500
Received: from d06nrmr1806.portsmouth.uk.ibm.com
	(d06nrmr1806.portsmouth.uk.ibm.com [9.149.39.193])
	by mtagate1.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p1GBbvkJ026106
	for <qemu-devel@nongnu.org>; Wed, 16 Feb 2011 11:37:57 GMT
Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com
	[9.149.37.251])
	by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id p1GBc3Cn1318966
	for <qemu-devel@nongnu.org>; Wed, 16 Feb 2011 11:38:03 GMT
Received: from d06av10.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av10.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with
	ESMTP id p1GBbvcY008087
	for <qemu-devel@nongnu.org>; Wed, 16 Feb 2011 04:37:57 -0700
Date: Wed, 16 Feb 2011 11:37:34 +0000
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Message-ID: <20110216113734.GE4836@stefanha-thinkpad.localdomain>
References: <cover.1297787220.git.mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1297787220.git.mst@redhat.com>
Subject: [Qemu-devel] Re: [PATCHv2 0/3] e1000: multi-buffer packet support
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kwolf@redhat.com, Jes.Sorensen@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, Alex Williamson <alex.williamson@redhat.com>

On Tue, Feb 15, 2011 at 06:27:44PM +0200, Michael S. Tsirkin wrote:
> e1000 supports multi-buffer packets larger than rxbuf_size.
> 
> This fixes the following (on linux):
> - in guest: ifconfig eth1 mtu 16110
> - in host: ifconfig tap0 mtu 16110
>            ping -s 16082 <guest-ip>
> 
> Red Hat bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=602205
> 
> Changes from v1:
> 	fix buffer overflow reported by Kevin
> 	added a patch to fix EOP spec violation reported by Juan
> 	added a patch to fix spec violation noted by myself
> 
> 
> Michael S. Tsirkin (3):
>   e1000: multi-buffer packet support
>   e1000: clear EOP for multi-buffer descriptors
>   e1000: verify we have buffers, upfront
> 
>  hw/e1000.c |   61 +++++++++++++++++++++++++++++++++++++++++++++++------------
>  1 files changed, 48 insertions(+), 13 deletions(-)

Took a quick look, looks good.

Stefan