From: Stefan Hajnoczi <stefanha@gmail.com>
To: "M. Mohan Kumar" <mohan@in.ibm.com>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [V5 PATCH 2/8] virtio-9p: Provide chroot environment server side interfaces
Date: Thu, 17 Feb 2011 08:54:08 +0000 [thread overview]
Message-ID: <20110217085333.GA11109@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1297858995-24676-3-git-send-email-mohan@in.ibm.com>
On Wed, Feb 16, 2011 at 05:53:09PM +0530, M. Mohan Kumar wrote:
> +static int chroot_daemonize(int chroot_sock)
> +{
> + sigset_t sigset;
> + struct rlimit nr_fd;
> + int fd;
> +
> + /* Block all signals for this process */
> + sigprocmask(SIG_SETMASK, &sigset, NULL);
sigset is an uninitialized local variable so the result of this is
undefined. We're missing sigfillset(&sigset).
Stefan
next prev parent reply other threads:[~2011-02-17 8:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 12:23 [Qemu-devel] [V5 PATCH 0/8] virtio-9p: Use chroot to safely access files in passthrough security model M. Mohan Kumar
2011-02-16 12:23 ` [Qemu-devel] [V5 PATCH 1/8] Implement qemu_read_full M. Mohan Kumar
2011-02-16 12:23 ` [Qemu-devel] [V5 PATCH 2/8] virtio-9p: Provide chroot environment server side interfaces M. Mohan Kumar
2011-02-17 8:54 ` Stefan Hajnoczi [this message]
2011-02-16 12:23 ` [Qemu-devel] [V5 PATCH 3/8] virtio-9p: Add client side interfaces for chroot environment M. Mohan Kumar
2011-02-16 12:23 ` [Qemu-devel] [V5 PATCH 4/8] virtio-9p: Add support to open a file in " M. Mohan Kumar
2011-02-17 10:23 ` [Qemu-devel] " Stefan Hajnoczi
2011-02-16 12:23 ` [Qemu-devel] [V5 PATCH 5/8] virtio-9p: Create support " M. Mohan Kumar
2011-02-16 12:23 ` [Qemu-devel] [V5 PATCH 6/8] virtio-9p: Support for creating special files M. Mohan Kumar
2011-02-17 10:49 ` [Qemu-devel] " Stefan Hajnoczi
2011-02-18 5:58 ` M. Mohan Kumar
2011-02-16 12:23 ` [Qemu-devel] [V5 PATCH 7/8] virtio-9p: Move file post creation changes to none security model M. Mohan Kumar
2011-02-16 12:23 ` [Qemu-devel] [V5 PATCH 8/8] virtio-9p: Chroot environment for other functions M. Mohan Kumar
2011-02-17 11:02 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217085333.GA11109@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=blauwirbel@gmail.com \
--cc=mohan@in.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).