From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=43933 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pq3Wl-0000x1-FO for qemu-devel@nongnu.org; Thu, 17 Feb 2011 08:04:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pq3Wk-0002pB-GV for qemu-devel@nongnu.org; Thu, 17 Feb 2011 08:04:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pq3Wk-0002og-97 for qemu-devel@nongnu.org; Thu, 17 Feb 2011 08:04:10 -0500 Date: Thu, 17 Feb 2011 18:33:24 +0530 From: Amit Shah Subject: Re: [Qemu-devel] [PATCH REBASE/RESEND 2/4] virtio-serial: Add description fields for qdev properties Message-ID: <20110217130324.GC27487@amit-x200.redhat.com> References: <2b49a1453925f808405eb380cab2f45f10fb6a5f.1296800130.git.amit.shah@redhat.com> <4D5AA56F.9040901@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D5AA56F.9040901@codemonkey.ws> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu list , Markus Armbruster On (Tue) 15 Feb 2011 [10:10:23], Anthony Liguori wrote: > >diff --git a/hw/virtio-serial.h b/hw/virtio-serial.h > >index a308196..2c5e336 100644 > >--- a/hw/virtio-serial.h > >+++ b/hw/virtio-serial.h > >@@ -57,6 +57,19 @@ struct virtio_console_control { > > > > /* == In-qemu interface == */ > > > >+#define PROP_VIRTSERIAL_IS_CONSOLE_DESC \ > >+ "An hvc console will be spawned in the guest if this is set." > >+ > >+#define PROP_VIRTSERIAL_NR_DESC \ > >+ "The 'number' for the port for predictable port numbers. Use this to " \ > >+ "spawn ports if you plan to migrate the guest." > >+ > >+#define PROP_VIRTSERIAL_CHR_DESC \ > >+ "The chardev to associate this port with." > >+ > >+#define PROP_VIRTSERIAL_NAME_DESC \ > >+ "Name for the port that's exposed to the guest for port discovery." > >+ > > Why are you using a #define instead of inlining the docs? These are shared by the generic and console ports. Amit