From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37627 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pq3a2-0002z9-MV
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 08:07:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Pq3a1-0004b9-E4
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 08:07:34 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52298)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Pq3a1-0004ac-7G
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 08:07:33 -0500
Date: Thu, 17 Feb 2011 18:36:57 +0530
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description
	field for qdev properties for documentation
Message-ID: <20110217130657.GD27487@amit-x200.redhat.com>
References: <cover.1296800129.git.amit.shah@redhat.com>
	<f82c12ab9864ba4211752e7df78be9735b9602a2.1296800130.git.amit.shah@redhat.com>
	<4D5AAD3E.6010201@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D5AAD3E.6010201@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu list <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>

On (Tue) 15 Feb 2011 [10:43:42], Anthony Liguori wrote:

> >  #define DEFINE_BLOCK_PROPERTIES(_state, _conf)                          \
> >-    DEFINE_PROP_DRIVE("drive", _state, _conf.bs),                       \
> >+    DEFINE_PROP_DRIVE("drive", _state, _conf.bs, ""),                   \
> >      DEFINE_PROP_UINT16("logical_block_size", _state,                    \
> >-                       _conf.logical_block_size, 512),                  \
> >+                       _conf.logical_block_size, 512, ""),              \
> >      DEFINE_PROP_UINT16("physical_block_size", _state,                   \
> >-                       _conf.physical_block_size, 512),                 \
> >-    DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 0),  \
> >-    DEFINE_PROP_UINT32("opt_io_size", _state, _conf.opt_io_size, 0),    \
> >-    DEFINE_PROP_INT32("bootindex", _state, _conf.bootindex, -1),        \
> >+                       _conf.physical_block_size, 512, ""),             \
> >+    DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 0, ""), \
> >+    DEFINE_PROP_UINT32("opt_io_size", _state, _conf.opt_io_size, 0, ""), \
> >+        DEFINE_PROP_INT32("bootindex", _state, _conf.bootindex, -1, ""), \
> >      DEFINE_PROP_UINT32("discard_granularity", _state, \
> >-                       _conf.discard_granularity, 0)
> >+                       _conf.discard_granularity, 0, "")
> 
> This is pretty horribly ugly.  If we were going this, we should at
> least introduce new defines that include a documentation field and
> not just add empty documentation fields.

We've discussed this in the past.  Once this patch series gets in,
I'll work to fill in the documentation here along with the
maintainers.

Also, an empty string is a reminder to people to add something here.

		Amit