From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50151 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pq44j-0008HC-C0
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 08:39:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Pq44i-0003WL-6m
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 08:39:17 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56565)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Pq44h-0003W1-RX
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 08:39:16 -0500
Date: Thu, 17 Feb 2011 19:09:01 +0530
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] [PATCH REBASE/RESEND 2/4] virtio-serial: Add
	description fields for qdev properties
Message-ID: <20110217133901.GB28478@amit-x200.redhat.com>
References: <cover.1296800129.git.amit.shah@redhat.com>
	<2b49a1453925f808405eb380cab2f45f10fb6a5f.1296800130.git.amit.shah@redhat.com>
	<4D5AA56F.9040901@codemonkey.ws>
	<20110217130324.GC27487@amit-x200.redhat.com>
	<4D5D1E90.4080501@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D5D1E90.4080501@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu list <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>

On (Thu) 17 Feb 2011 [07:11:44], Anthony Liguori wrote:
> On 02/17/2011 07:03 AM, Amit Shah wrote:
> >On (Tue) 15 Feb 2011 [10:10:23], Anthony Liguori wrote:
> >
> >>>diff --git a/hw/virtio-serial.h b/hw/virtio-serial.h
> >>>index a308196..2c5e336 100644
> >>>--- a/hw/virtio-serial.h
> >>>+++ b/hw/virtio-serial.h
> >>>@@ -57,6 +57,19 @@ struct virtio_console_control {
> >>>
> >>>  /* == In-qemu interface == */
> >>>
> >>>+#define PROP_VIRTSERIAL_IS_CONSOLE_DESC                                 \
> >>>+    "An hvc console will be spawned in the guest if this is set."
> >>>+
> >>>+#define PROP_VIRTSERIAL_NR_DESC                                         \
> >>>+    "The 'number' for the port for predictable port numbers. Use this to " \
> >>>+    "spawn ports if you plan to migrate the guest."
> >>>+
> >>>+#define PROP_VIRTSERIAL_CHR_DESC                \
> >>>+    "The chardev to associate this port with."
> >>>+
> >>>+#define PROP_VIRTSERIAL_NAME_DESC                \
> >>>+    "Name for the port that's exposed to the guest for port discovery."
> >>>+
> >>Why are you using a #define instead of inlining the docs?
> >These are shared by the generic and console ports.
> 
> Are the properties the same?  Should a common properties define be
> used like with network and disk devices?

Yes, that's something that needs to be done, at least for NR and NAME
properties.

		Amit