From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37158 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pq8pb-0000x9-TS
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 13:44:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1Pq8pa-0004Dl-A4
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 13:43:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:14201)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1Pq8pa-0004DZ-3P
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 13:43:58 -0500
Date: Thu, 17 Feb 2011 16:17:27 -0200
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20110217181727.GA12721@amt.cnet>
References: <cover.1297758211.git.jan.kiszka@siemens.com>
	<56bf7460c65f7fc5c89fa9673b880a556b99e0fc.1297758211.git.jan.kiszka@siemens.com>
	<20110217163534.GB10918@amt.cnet> <4D5D558B.10406@siemens.com>
	<20110217175559.GA12113@amt.cnet> <4D5D6343.6060508@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D5D6343.6060508@siemens.com>
Subject: [Qemu-devel] Re: [PATCH 08/13] kvm: x86: Inject pending MCE events
 on state writeback
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>, Huang Ying <ying.huang@intel.com>, Jin Dongming <jin.dongming@np.css.fujitsu.com>

On Thu, Feb 17, 2011 at 07:04:51PM +0100, Jan Kiszka wrote:
> >>> Should not manipulate mp_state of a running vcpu (should only do that
> >>> for migration when vcpu is stopped), since its managed by the kernel,
> >>> for irqchip case.
> >>
> >> Not for asynchronously injected MCEs. The target CPU would simply
> >> oversleep them. MCEs are not in the scope of the in-kernel irqchip.
> > 
> > Pending MCE exception could break out of in-kernel halt emulation.
> 
> Can't follow. What do you mean? That the kernel already takes care? I
> didn't find a trace, so I added that code.

Nevermind. This is rare and "halted -> running" transition in userspace 
is harmless.