From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49198 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PrCGT-00078X-EO for qemu-devel@nongnu.org; Sun, 20 Feb 2011 11:36:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PrCGQ-0005rf-El for qemu-devel@nongnu.org; Sun, 20 Feb 2011 11:36:05 -0500 Received: from hall.aurel32.net ([88.191.126.93]:52071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PrCGQ-0005rN-A1 for qemu-devel@nongnu.org; Sun, 20 Feb 2011 11:36:02 -0500 Date: Sun, 20 Feb 2011 17:35:58 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH v2 0/2] target-arm: fix Neon VUZP, VZIP instructions Message-ID: <20110220163558.GH18619@volta.aurel32.net> References: <1297678969-3433-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1297678969-3433-1-git-send-email-peter.maydell@linaro.org> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org On Mon, Feb 14, 2011 at 10:22:47AM +0000, Peter Maydell wrote: > This patch series fixes bugs in the Neon VZIP and VUZP instructions > by abandoning the existing inline implementations in favour of > calling out to straightforward helper functions. The inline routines > could generate 50+ TCG ops each, which is well over the recommended > limit in tcg/README for using helpers instead; they also did > not give the correct results... > > I've tested these patches using the usual random instruction > generation approach. > > V2 changes: moved the decoding of register numbers, size and q > flag out of the helper functions into translate.c; split the > helpers up into one per (size, q) combination. > > Peter Maydell (2): > target-arm: Move Neon VUZP to helper functions > target-arm: Move Neon VZIP to helper functions > > target-arm/helpers.h | 11 +++ > target-arm/neon_helper.c | 186 +++++++++++++++++++++++++++++++++++++++ > target-arm/translate.c | 215 +++++++++++++++------------------------------- > 3 files changed, 267 insertions(+), 145 deletions(-) > Thanks, both applied. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net