From: Aurelien Jarno <aurelien@aurel32.net>
To: digit@google.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qdev: Fix printout of bit device properties with bit index >= 8
Date: Sun, 20 Feb 2011 18:54:16 +0100 [thread overview]
Message-ID: <20110220175416.GR18619@volta.aurel32.net> (raw)
In-Reply-To: <1294697500-3706-1-git-send-email-digit@google.com>
On Mon, Jan 10, 2011 at 11:11:40PM +0100, digit@google.com wrote:
> From: David 'Digit' Turner <digit@google.com>
>
> Signed-off-by: David 'Digit' Turner <digit@google.com>
> ---
> hw/qdev-properties.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
> index 9219cd7..d5d9591 100644
> --- a/hw/qdev-properties.c
> +++ b/hw/qdev-properties.c
> @@ -50,7 +50,7 @@ static int parse_bit(DeviceState *dev, Property *prop, const char *str)
>
> static int print_bit(DeviceState *dev, Property *prop, char *dest, size_t len)
> {
> - uint8_t *p = qdev_get_prop_ptr(dev, prop);
> + uint32_t *p = qdev_get_prop_ptr(dev, prop);
> return snprintf(dest, len, (*p & qdev_get_prop_mask(prop)) ? "on" : "off");
> }
>
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2011-02-20 17:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 22:11 [Qemu-devel] [PATCH] qdev: Fix printout of bit device properties with bit index >= 8 digit
2011-01-11 9:23 ` Markus Armbruster
2011-02-20 17:54 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110220175416.GR18619@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=digit@google.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).