From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39418 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PrDZU-0006bV-Q1
	for qemu-devel@nongnu.org; Sun, 20 Feb 2011 12:59:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1PrDUD-0003IZ-MV
	for qemu-devel@nongnu.org; Sun, 20 Feb 2011 12:54:22 -0500
Received: from hall.aurel32.net ([88.191.126.93]:47470)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1PrDUD-0003IU-Go
	for qemu-devel@nongnu.org; Sun, 20 Feb 2011 12:54:21 -0500
Date: Sun, 20 Feb 2011 18:54:16 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] qdev: Fix printout of bit device
	properties with bit index >= 8
Message-ID: <20110220175416.GR18619@volta.aurel32.net>
References: <1294697500-3706-1-git-send-email-digit@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1294697500-3706-1-git-send-email-digit@google.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: digit@google.com
Cc: qemu-devel@nongnu.org

On Mon, Jan 10, 2011 at 11:11:40PM +0100, digit@google.com wrote:
> From: David 'Digit' Turner <digit@google.com>
> 
> Signed-off-by: David 'Digit' Turner <digit@google.com>
> ---
>  hw/qdev-properties.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
> index 9219cd7..d5d9591 100644
> --- a/hw/qdev-properties.c
> +++ b/hw/qdev-properties.c
> @@ -50,7 +50,7 @@ static int parse_bit(DeviceState *dev, Property *prop, const char *str)
>  
>  static int print_bit(DeviceState *dev, Property *prop, char *dest, size_t len)
>  {
> -    uint8_t *p = qdev_get_prop_ptr(dev, prop);
> +    uint32_t *p = qdev_get_prop_ptr(dev, prop);
>      return snprintf(dest, len, (*p & qdev_get_prop_mask(prop)) ? "on" : "off");
>  }
>  

Thanks, applied.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net