From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45766 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PrEHz-0007wx-BE for qemu-devel@nongnu.org; Sun, 20 Feb 2011 13:45:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PrEHw-0003wv-LB for qemu-devel@nongnu.org; Sun, 20 Feb 2011 13:45:45 -0500 Received: from hall.aurel32.net ([88.191.126.93]:58572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PrEHw-0003wZ-F3 for qemu-devel@nongnu.org; Sun, 20 Feb 2011 13:45:44 -0500 Date: Sun, 20 Feb 2011 19:45:42 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] Fix obvious mistake in pxa2xx i2s driver Message-ID: <20110220184542.GL4580@hall.aurel32.net> References: <1297702750-32203-1-git-send-email-anarsoul@gmail.com> <20110220182446.GU18619@volta.aurel32.net> <201102202039.20920.anarsoul@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <201102202039.20920.anarsoul@gmail.com> Sender: Aurelien Jarno List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vasily Khoruzhick Cc: "qemu-devel@nongnu.org" On Sun, Feb 20, 2011 at 08:39:20PM +0200, Vasily Khoruzhick wrote: > On Sunday 20 February 2011 20:24:46 Aurelien Jarno wrote: > > > The fix looks fine, but the resulting code is probably over > > engineered... What about: > > > > s->enable = (value & 9) == 1; > > > > ? > > Looks OK to me. > Can you please provide a new version with that code instead, I'll apply it. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net