From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Fix obvious mistake in pxa2xx i2s driver
Date: Sun, 20 Feb 2011 20:39:20 +0200 [thread overview]
Message-ID: <201102202039.20920.anarsoul@gmail.com> (raw)
In-Reply-To: <20110220182446.GU18619@volta.aurel32.net>
On Sunday 20 February 2011 20:24:46 Aurelien Jarno wrote:
> The fix looks fine, but the resulting code is probably over
> engineered... What about:
>
> s->enable = (value & 9) == 1;
>
> ?
Looks OK to me.
Regards
Vasily
next prev parent reply other threads:[~2011-02-20 18:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 16:59 [Qemu-devel] [PATCH] Fix obvious mistake in pxa2xx i2s driver Vasily Khoruzhick
2011-02-20 14:19 ` [Qemu-devel] " Vasily Khoruzhick
2011-02-20 18:24 ` [Qemu-devel] " Aurelien Jarno
2011-02-20 18:39 ` Vasily Khoruzhick [this message]
2011-02-20 18:45 ` Aurelien Jarno
2011-02-20 19:23 ` [Qemu-devel] [PATCH v2] " Vasily Khoruzhick
2011-02-20 19:29 ` [Qemu-devel] " Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102202039.20920.anarsoul@gmail.com \
--to=anarsoul@gmail.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).