From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39348 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PrEBv-0004rd-DJ
	for qemu-devel@nongnu.org; Sun, 20 Feb 2011 13:39:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anarsoul@gmail.com>) id 1PrEBu-0002kG-Bo
	for qemu-devel@nongnu.org; Sun, 20 Feb 2011 13:39:31 -0500
Received: from mail-fx0-f45.google.com ([209.85.161.45]:37412)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anarsoul@gmail.com>) id 1PrEBu-0002k3-1w
	for qemu-devel@nongnu.org; Sun, 20 Feb 2011 13:39:30 -0500
Received: by fxm11 with SMTP id 11so481071fxm.4
	for <qemu-devel@nongnu.org>; Sun, 20 Feb 2011 10:39:29 -0800 (PST)
From: Vasily Khoruzhick <anarsoul@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Fix obvious mistake in pxa2xx i2s driver
Date: Sun, 20 Feb 2011 20:39:20 +0200
References: <1297702750-32203-1-git-send-email-anarsoul@gmail.com>
	<20110220182446.GU18619@volta.aurel32.net>
In-Reply-To: <20110220182446.GU18619@volta.aurel32.net>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201102202039.20920.anarsoul@gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Sunday 20 February 2011 20:24:46 Aurelien Jarno wrote:

> The fix looks fine, but the resulting code is probably over
> engineered... What about:
> 
>          s->enable = (value & 9) == 1;
> 
> ?

Looks OK to me.

Regards
Vasily