From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44028 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PskDq-0001DA-G6 for qemu-devel@nongnu.org; Thu, 24 Feb 2011 18:03:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PskDo-0008KW-Uk for qemu-devel@nongnu.org; Thu, 24 Feb 2011 18:03:45 -0500 Received: from mail.serverraum.org ([78.47.150.89]:42398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PskDo-0008JQ-PR for qemu-devel@nongnu.org; Thu, 24 Feb 2011 18:03:44 -0500 From: Michael Walle Subject: Re: [Qemu-devel] [PATCH 00/17 v3] LatticeMico32 target Date: Fri, 25 Feb 2011 00:03:37 +0100 References: <1297982718-21865-1-git-send-email-michael@walle.cc> In-Reply-To: <1297982718-21865-1-git-send-email-michael@walle.cc> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201102250003.37805.michael@walle.cc> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , "Edgar E. Iglesias" , Alexander Graf , Richard Henderson Am Donnerstag 17 Februar 2011, 23:45:01 schrieb Michael Walle: > This patchset adds support for the LatticeMico32 softcore processor by > Lattice Semiconductor. > > Changes since v2: > - lots of CODING_STYLE fixes > - reworked pic and juart model, CPUState is not passed anymore > - use qdev reset field instead of qemu_register_reset() > - add missing include guards > - merged lm32_pic_cpu.c into boards file > - removed buggy qemu_irq_lower() in reset functions > - converted hw_error to error_report() > > Changes since v1: > - removed variables which are no longer in use > - replaced some tcg ops with specialized ones > - kill VM in case of an unknown opcode > - fixed tracepoints format strings to match existing ones Any comments/reviews on this patchset? I've changed the opcode decoding to use a lookup table instead of the for- loop. If you don't mind, i would submit a patch after the above is merged. Or, alternatively, if there is another patchset version, i'll integrate it into that ;) -- Michael