From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59967 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PtmJB-0004Vl-Bw
	for qemu-devel@nongnu.org; Sun, 27 Feb 2011 14:29:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1PtmJ6-0001sA-As
	for qemu-devel@nongnu.org; Sun, 27 Feb 2011 14:29:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:7425)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1PtmJ5-0001rw-P4
	for qemu-devel@nongnu.org; Sun, 27 Feb 2011 14:29:28 -0500
Date: Sun, 27 Feb 2011 21:29:18 +0200
From: Alon Levy <alevy@redhat.com>
Subject: Re: [Qemu-devel] Re: kvm crashes with spice while loading qxl
Message-ID: <20110227192917.GE14445@playa.redhat.com>
References: <AANLkTint9-P-1jD5pbXstzPcYueLHQ68Rd0T_Chz6xRN@mail.gmail.com>
	<4D68F20D.2020401@web.de> <20110227190312.GA14445@playa.redhat.com>
	<4D6AA1DE.6020102@web.de> <20110227191608.GB14445@playa.redhat.com>
	<4D6AA585.4020204@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D6AA585.4020204@web.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: xming <xmingske@gmail.com>, Gerd Hoffmann <kraxel@redhat.com>, kvm@vger.kernel.org, qemu-devel <qemu-devel@nongnu.org>

On Sun, Feb 27, 2011 at 08:27:01PM +0100, Jan Kiszka wrote:
> On 2011-02-27 20:16, Alon Levy wrote:
> > On Sun, Feb 27, 2011 at 08:11:26PM +0100, Jan Kiszka wrote:
> >> On 2011-02-27 20:03, Alon Levy wrote:
> >>> On Sat, Feb 26, 2011 at 01:29:01PM +0100, Jan Kiszka wrote:
> >>>> On 2011-02-26 12:43, xming wrote:
> >>>>> When trying to start X (and it loads qxl driver) the kvm process just crashes.
> >>>
> >>> This is fixed by Gerd's attached patch (taken from rhel repository, don't know
> >>> why it wasn't pushed to qemu-kvm upstream). I'll send it to kvm list as well (separate email).
> >>
> >> Patch looks OK on first glance, but the changelog is misleading: This
> >> was broken for _both_ trees, but upstream didn't detect the bug.
> >>
> > 
> > The trees the patch commit message refers to are qemu and qemu-kvm.
> 
> The same did I.
> 
> > qemu doesn't even have cpu_single_env.
> 
> Really? Check again. :)

Sorry, grepped the wrong repo. I'll send this to qemu-devel too then.

> 
> > It didn't talk about two qemu-kvm trees.
> > 
> >> My concerns regarding other side effects of juggling with global mutex
> >> in spice code remain.
> > 
> > I know there used to be a mutex in spice code and during the upstreaming process it
> > got ditched in favor of the qemu global io mutex. I would have rather deferred this
> > to Gerd since he wrote this, but he is not available atm.
> 
> It's not necessarily bad to drop the io mutex, but it is more tricky
> than it may appear on first glance.
> 
> Jan
>