From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52235 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PuOuy-0002QL-2I for qemu-devel@nongnu.org; Tue, 01 Mar 2011 07:43:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PuOuw-0000qL-UE for qemu-devel@nongnu.org; Tue, 01 Mar 2011 07:43:07 -0500 Received: from verein.lst.de ([213.95.11.210]:56942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PuOuw-0000ou-8n for qemu-devel@nongnu.org; Tue, 01 Mar 2011 07:43:06 -0500 Date: Tue, 1 Mar 2011 13:42:54 +0100 From: Christoph Hellwig Subject: Re: [Qemu-devel] [RFC][PATCH 0/2] Allow cache settings for block devices to be changed at runtime. Message-ID: <20110301124254.GA29485@lst.de> References: <20110228171956.05a84fb9@zephyr> <4D6BBB72.6040205@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Anthony Liguori , Stefan Hajnoczi , qemu-devel , Ananth Narayan , Prerna Saxena , Christoph Hellwig The only way to change the cache settings is from the guest. Without that we're guranteed to lose data when going from WCE=0 to WCE=1. I have patches to do that, and to allow changing O_DIRECT via a monitor command, but to toggle O_SYNC via fcntl I first need to get a kernel patch in as that's currently not allowed to be changed at runtime.