From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53955 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PvHeo-0005qc-Ek
	for qemu-devel@nongnu.org; Thu, 03 Mar 2011 18:10:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <adam@os.inf.tu-dresden.de>) id 1PvHen-0003Tq-2W
	for qemu-devel@nongnu.org; Thu, 03 Mar 2011 18:10:06 -0500
Received: from os.inf.tu-dresden.de ([141.76.48.99]:48146)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <adam@os.inf.tu-dresden.de>) id 1PvHem-0003TQ-TZ
	for qemu-devel@nongnu.org; Thu, 03 Mar 2011 18:10:05 -0500
Date: Fri, 4 Mar 2011 00:09:59 +0100
From: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
Subject: Re: [Qemu-devel] [PATCH 2/3] target-arm: Implement cp15 VA->PA
	translation
Message-ID: <20110303230959.GA5437@os.inf.tu-dresden.de>
References: <1298330372-1254-1-git-send-email-adam@os.inf.tu-dresden.de>
	<1298330372-1254-3-git-send-email-adam@os.inf.tu-dresden.de>
	<AANLkTi=x-BHdz2B78-Lu0upTU_hiM4zKsCWRPOWAP=9k@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <AANLkTi=x-BHdz2B78-Lu0upTU_hiM4zKsCWRPOWAP=9k@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org


On Thu Mar 03, 2011 at 22:59:03 +0000, Peter Maydell wrote:
> On 21 February 2011 23:19, Adam Lackorzynski <adam@os.inf.tu-dresden.de> =
wrote:
> > diff --git a/target-arm/machine.c b/target-arm/machine.c
> > index 3925d3a..a18b7dc 100644
> > --- a/target-arm/machine.c
> > +++ b/target-arm/machine.c
> > @@ -41,6 +41,7 @@ void cpu_save(QEMUFile *f, void *opaque)
> > =A0 =A0 }
> > =A0 =A0 qemu_put_be32(f, env->cp15.c6_insn);
> > =A0 =A0 qemu_put_be32(f, env->cp15.c6_data);
> > + =A0 =A0qemu_put_be32(f, env->cp15.c7_par);
> > =A0 =A0 qemu_put_be32(f, env->cp15.c9_insn);
> > =A0 =A0 qemu_put_be32(f, env->cp15.c9_data);
> > =A0 =A0 qemu_put_be32(f, env->cp15.c13_fcse);
> > @@ -148,6 +149,7 @@ int cpu_load(QEMUFile *f, void *opaque, int version=
_id)
> > =A0 =A0 }
> > =A0 =A0 env->cp15.c6_insn =3D qemu_get_be32(f);
> > =A0 =A0 env->cp15.c6_data =3D qemu_get_be32(f);
> > + =A0 =A0env->cp15.c7_par =3D qemu_get_be32(f);
> > =A0 =A0 env->cp15.c9_insn =3D qemu_get_be32(f);
> > =A0 =A0 env->cp15.c9_data =3D qemu_get_be32(f);
> > =A0 =A0 env->cp15.c13_fcse =3D qemu_get_be32(f);
>=20
> Comments on another patch left me wondering whether we should
> be bumping a version number here somewhere[*], since we're changing
> the load/store state format by adding another field. Anybody
> care to agree/disagree?

Looks like a reasonable thing to do. I'll add it to my patch set.
=20

Adam
--=20
Adam                 adam@os.inf.tu-dresden.de
  Lackorzynski         http://os.inf.tu-dresden.de/~adam/