From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45249 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PwaME-0000qs-HI
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:20:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1PwaMB-0003Oo-2o
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:20:18 -0500
Received: from mail-ey0-f173.google.com ([209.85.215.173]:40981)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1PwaMA-0003OX-UU
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:20:15 -0500
Received: by eyb6 with SMTP id 6so1455191eyb.4
	for <qemu-devel@nongnu.org>; Mon, 07 Mar 2011 05:20:13 -0800 (PST)
Date: Mon, 7 Mar 2011 14:20:09 +0100
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 00/17 v3] LatticeMico32 target
Message-ID: <20110307132009.GE5852@laped.lan>
References: <1297982718-21865-1-git-send-email-michael@walle.cc>
	<201102250003.37805.michael@walle.cc>
	<20110301213158.GB7509@laped.lan>
	<201103062347.56232.michael@walle.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <201103062347.56232.michael@walle.cc>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Walle <michael@walle.cc>
Cc: Blue Swirl <blauwirbel@gmail.com>, Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On Sun, Mar 06, 2011 at 11:47:55PM +0100, Michael Walle wrote:
> Am Dienstag 01 März 2011, 22:31:58 schrieb Edgar E. Iglesias:
> > On Fri, Feb 25, 2011 at 12:03:37AM +0100, Michael Walle wrote:
> > > Am Donnerstag 17 Februar 2011, 23:45:01 schrieb Michael Walle:
> > > > This patchset adds support for the LatticeMico32 softcore processor by
> > > > Lattice Semiconductor.
> > > > 
> > > > Changes since v2:
> > > >  - lots of CODING_STYLE fixes
> > > >  - reworked pic and juart model, CPUState is not passed anymore
> > > >  - use qdev reset field instead of qemu_register_reset()
> > > >  - add missing include guards
> > > >  - merged lm32_pic_cpu.c into boards file
> > > >  - removed buggy qemu_irq_lower() in reset functions
> > > >  - converted hw_error to error_report()
> > > > 
> > > > Changes since v1:
> > > >  - removed variables which are no longer in use
> > > >  - replaced some tcg ops with specialized ones
> > > >  - kill VM in case of an unknown opcode
> > > >  - fixed tracepoints format strings to match existing ones
> > > 
> > > Any comments/reviews on this patchset?
> > > 
> > > I've changed the opcode decoding to use a lookup table instead of the
> > > for- loop. If you don't mind, i would submit a patch after the above is
> > > merged. Or, alternatively, if there is another patchset version, i'll
> > > integrate it into that ;)
> > 
> > Hi, lets do v3 first.
> > 
> > Do you have a public tree to pull from?
> My git repository is at:
> http://git.serverraum.org/git/mw/qemu-lm32.git/
> 
> There i create a tag 'for-upstream-v3' which contains the patchset rebased on 
> the latest official HEAD.

Thanks, I've applied v3.

Got a conflict on patch nr 16 though. Would be good if you could double check
upstreams configure to verify I resolved it correctly...

Cheers