From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34230 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PwalP-0007hU-A2
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:46:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1PwalN-00014c-6J
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:46:19 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52464)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1PwalM-00014M-Q7
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:46:17 -0500
Date: Mon, 7 Mar 2011 13:46:10 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 10/22] qapi: add core QMP server support
Message-ID: <20110307134610.GP21899@redhat.com>
References: <1299460984-15849-1-git-send-email-aliguori@us.ibm.com>
	<1299460984-15849-11-git-send-email-aliguori@us.ibm.com>
	<AANLkTiks5UZso66YVjN6mXf8R2wZ4CFpPnzQ3=wuGpu8@mail.gmail.com>
	<4D74E01D.9020304@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4D74E01D.9020304@codemonkey.ws>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Adam Litke <aglitke@linux.vnet.ibm.com>

On Mon, Mar 07, 2011 at 07:39:41AM -0600, Anthony Liguori wrote:
> On 03/07/2011 07:09 AM, Stefan Hajnoczi wrote:
> >On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori<aliguori@us.ibm.com>  wrote:
> >>+char *qobject_as_string(QObject *obj)
> >>+{
> >>+    char buffer[1024];
> >>+
> >>+    switch (qobject_type(obj)) {
> >>+    case QTYPE_QINT:
> >>+        snprintf(buffer, sizeof(buffer), "%" PRId64,
> >>+                 qint_get_int(qobject_to_qint(obj)));
> >>+        return qemu_strdup(buffer);
> >>+    case QTYPE_QSTRING:
> >>+        return qemu_strdup(qstring_get_str(qobject_to_qstring(obj)));
> >>+    case QTYPE_QFLOAT:
> >>+        snprintf(buffer, sizeof(buffer), "%.17g",
> >>+                 qfloat_get_double(qobject_to_qfloat(obj)));
> >>+        return qemu_strdup(buffer);
> >qemu_asprintf() would be a nice helper function to have ;).
> 
> Indeed :-)

Since you've introduced glib, you get that function for free:

    g_strdup_printf()/g_strdup_vprintf()

similarly qemu_strdup & malloc related friends could be replaced with
the equivalent glib functions.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|