From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41452 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Py775-0007Cu-Qg for qemu-devel@nongnu.org; Fri, 11 Mar 2011 13:31:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Py774-0001Tz-G6 for qemu-devel@nongnu.org; Fri, 11 Mar 2011 13:30:59 -0500 Received: from mail.codesourcery.com ([38.113.113.100]:38439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Py774-0001Tm-6R for qemu-devel@nongnu.org; Fri, 11 Mar 2011 13:30:58 -0500 Date: Fri, 11 Mar 2011 10:30:57 -0800 From: Nathan Froyd Subject: Re: [Qemu-devel] [PATCH 1/7] target-arm: Make Neon helper routines use correct FP status Message-ID: <20110311183057.GV23686@codesourcery.com> References: <1299867146-22049-1-git-send-email-peter.maydell@linaro.org> <1299867146-22049-2-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1299867146-22049-2-git-send-email-peter.maydell@linaro.org> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org On Fri, Mar 11, 2011 at 06:12:20PM +0000, Peter Maydell wrote: > Make the Neon helper routines use the correct FP status from > the CPUEnv rather than using a dummy static one. This means > they will correctly handle denormals and NaNs and will set > FPSCR exception bits properly. Is there a reason that you don't simply use the global env rather than passing in an extra parameter everywhere? I wonder if it'd be worthwhile just to merge these functions into op_helper.c, since we have a proper FP status for NEON bits now. -Nathan