From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47191 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pz0Ro-0000y0-7T
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 01:36:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <froydnj@codesourcery.com>) id 1Pz0Rn-0005ke-2X
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 01:36:04 -0400
Received: from mail.codesourcery.com ([38.113.113.100]:57590)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <froydnj@codesourcery.com>) id 1Pz0Rm-0005kT-PV
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 01:36:03 -0400
Date: Sun, 13 Mar 2011 22:35:59 -0700
From: Nathan Froyd <froydnj@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 1/7] target-arm: Make Neon helper routines
	use correct FP status
Message-ID: <20110314053558.GA30619@codesourcery.com>
References: <1299867146-22049-1-git-send-email-peter.maydell@linaro.org>
	<1299867146-22049-2-git-send-email-peter.maydell@linaro.org>
	<20110311183057.GV23686@codesourcery.com>
	<AANLkTikicYzL7wLHQWP2=h7w5pgvuWhJpK38jChFz6Ff@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTikicYzL7wLHQWP2=h7w5pgvuWhJpK38jChFz6Ff@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org

On Fri, Mar 11, 2011 at 10:31:31PM +0000, Peter Maydell wrote:
> On 11 March 2011 18:30, Nathan Froyd <froydnj@codesourcery.com> wrote:
> > Is there a reason that you don't simply use the global env rather than
> > passing in an extra parameter everywhere?
> 
> Just following the pattern that generally seems to be used by
> most helper functions, ie if you want the CPU env pass it in
> as a parameter. As far as I know, you can't use the global
> env unless you're in op_helper.c because that's the only
> source file compiled with the right flags.

Oh, right.  I am ambivalent as to whether passing env to such functions
is the right thing to do or not.

> > I wonder if it'd be worthwhile just to merge these functions into
> > op_helper.c, since we have a proper FP status for NEON bits now.
> 
> Why move these and not (for instance) the VFP helpers
> in helper.c which use the CPU env for more or less the
> same reasons?

No reason, other than that I wasn't thinking about the VFP helpers. :)

-Nathan