From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53312 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pz8RA-0005WR-7a
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 10:07:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1Pz8R8-0007vP-Q7
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 10:07:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:14813)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1Pz8R8-0007vI-EC
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 10:07:54 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2EE7rfv011005
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 14 Mar 2011 10:07:53 -0400
Date: Mon, 14 Mar 2011 14:07:49 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus
Message-ID: <20110314140749.GD23458@redhat.com>
References: <1298460024-23591-1-git-send-email-alevy@redhat.com>
	<1298460024-23591-2-git-send-email-alevy@redhat.com>
	<4D7E1E33.1070801@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4D7E1E33.1070801@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Alon Levy <alevy@redhat.com>, qemu-devel@nongnu.org

On Mon, Mar 14, 2011 at 02:54:59PM +0100, Jes Sorensen wrote:
> On 02/23/11 12:20, Alon Levy wrote:
> > diff --git a/configure b/configure
> > index 791b71d..147aab3 100755
> > --- a/configure
> > +++ b/configure
> > @@ -174,6 +174,7 @@ trace_backend="nop"
> >  trace_file="trace"
> >  spice=""
> >  rbd=""
> > +smartcard="yes"
> 
> IMHO smartcard support shouldn't be enabled per default. The userbase is
> limited.

Deciding based on importance/size of userbase is rather subjective.
IMHO all features should be enabled by default, but if they depend
on a 3rd party library that isn't installed on the build host, they
should automatically disable themselves. eg

 * [the default]       - on, if external library is present, off otherwise
 * --enable-<feature>  - always on, raise error if external library is missing
 * --disable-<feature> - always off,

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|