From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49744 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PzDJx-0004HF-0h
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 15:20:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PzDIs-00035B-T9
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 15:19:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64966)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PzDIs-000356-JT
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 15:19:42 -0400
Date: Mon, 14 Mar 2011 16:19:37 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20110314161937.57045e29@doriath>
In-Reply-To: <1299877249-13433-6-git-send-email-aliguori@us.ibm.com>
References: <1299877249-13433-1-git-send-email-aliguori@us.ibm.com>
	<1299877249-13433-6-git-send-email-aliguori@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 05/11] qerror: add new error message for
 invalid enum values
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Michael@gnu.org, qemu-devel@nongnu.org, Roth <mdroth@us.ibm.com>, Markus Armbruster <armbru@redhat.com>

On Fri, 11 Mar 2011 15:00:43 -0600
Anthony Liguori <aliguori@us.ibm.com> wrote:

> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> 
> diff --git a/qerror.c b/qerror.c
> index 78d3884..5a1e637 100644
> --- a/qerror.c
> +++ b/qerror.c
> @@ -109,6 +109,10 @@ static const QErrorStringTable qerror_table[] = {
>          .desc      = "Duplicate ID '%(id)' for %(object)",
>      },
>      {
> +        .error_fmt = QERR_ENUM_VALUE_INVALID,
> +        .desc      = "Enum value '%(value)' is invalid for type '%(type)'",
> +    },

This doesn't seem to be used.

> +    {
>          .error_fmt = QERR_FD_NOT_FOUND,
>          .desc      = "File descriptor named '%(name)' not found",
>      },
> diff --git a/qerror.h b/qerror.h
> index 495d0a4..35e7253 100644
> --- a/qerror.h
> +++ b/qerror.h
> @@ -98,6 +98,9 @@ void qerror_set_desc(QError *qerr, const char *fmt);
>  #define QERR_DUPLICATE_ID \
>      "{ 'class': 'DuplicateId', 'data': { 'id': %s, 'object': %s } }"
>  
> +#define QERR_ENUM_VALUE_INVALID \
> +    "{ 'class': 'EnumValueInvalid', 'data': { 'type': %s, 'value': %s } }"
> +
>  #define QERR_FD_NOT_FOUND \
>      "{ 'class': 'FdNotFound', 'data': { 'name': %s } }"
>