From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42506 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzE1a-0006n3-23 for qemu-devel@nongnu.org; Mon, 14 Mar 2011 16:05:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzDv8-0002CD-96 for qemu-devel@nongnu.org; Mon, 14 Mar 2011 15:59:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzDv7-0002C9-VB for qemu-devel@nongnu.org; Mon, 14 Mar 2011 15:59:14 -0400 Date: Mon, 14 Mar 2011 16:30:05 -0300 From: Luiz Capitulino Message-ID: <20110314163005.624a2db3@doriath> In-Reply-To: <4D7E6B75.8080801@us.ibm.com> References: <1299877249-13433-1-git-send-email-aliguori@us.ibm.com> <1299877249-13433-5-git-send-email-aliguori@us.ibm.com> <20110314161853.0b9f5921@doriath> <4D7E6B75.8080801@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 04/11] qerror: split out the reporting bits of QError List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Paolo Bonzini , Michael@gnu.org, qemu-devel@nongnu.org, Roth , Markus Armbruster On Mon, 14 Mar 2011 14:24:37 -0500 Anthony Liguori wrote: > On 03/14/2011 02:18 PM, Luiz Capitulino wrote: > > On Fri, 11 Mar 2011 15:00:42 -0600 > > Anthony Liguori wrote: > > > >> These make it very hard to compile QError outside of QEMU. > > Why would someone do this? > > libqmp > > It's very nice to have client code that convert QMP errors to human > readable strings. Ok. I'm not sure if I would bother doing this kind of change in this series (as it's mainly re-working internal stuff) but, this has to be explained in the log message then.