From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58448 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PzEHN-0005Zg-TX
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 16:22:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PzEHM-0006ih-Jj
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 16:22:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32937)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PzEHM-0006iZ-4i
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 16:22:12 -0400
Date: Mon, 14 Mar 2011 17:22:07 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 02/11] qerror: expose a function to
	format an error
Message-ID: <20110314172207.15587e00@doriath>
In-Reply-To: <4D7E7049.10304@us.ibm.com>
References: <1299877249-13433-1-git-send-email-aliguori@us.ibm.com>
	<1299877249-13433-3-git-send-email-aliguori@us.ibm.com>
	<4D7A8F56.2080703@us.ibm.com> <20110314161728.36c3ca7e@doriath>
	<4D7E6C22.8010102@codemonkey.ws> <20110314163747.77392d06@doriath>
	<4D7E7049.10304@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Michael@gnu.org, qemu-devel@nongnu.org, Roth <mdroth@us.ibm.com>, Markus Armbruster <armbru@redhat.com>

On Mon, 14 Mar 2011 14:45:13 -0500
Anthony Liguori <aliguori@us.ibm.com> wrote:

> On 03/14/2011 02:37 PM, Luiz Capitulino wrote:
> >
> > qerror_abort() only exists for debugging purposes. I won't say its perfect,
> > but it's better than nothing and has already saved some time when writing
> > new errors.
> >
> > I'm fine dropping it as long as there's a better replacement, which is
> > not the case here. There's even a hunk that replaces qerror_abort() for
> > a plain abort().
> 
> Yes, that's the replacement.

It's not a good one: it makes the current code a bit worse and we don't know
how and when the error classes are going to be replaced.

Maybe a better merge plan would be to work on errors first. Completely drop
qerror according to qapi needs, and then put the rest of the stuff on top.