From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40411 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzEgr-0000GH-Fp for qemu-devel@nongnu.org; Mon, 14 Mar 2011 16:48:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzEgq-0002us-1K for qemu-devel@nongnu.org; Mon, 14 Mar 2011 16:48:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzEgp-0002uP-LN for qemu-devel@nongnu.org; Mon, 14 Mar 2011 16:48:32 -0400 Date: Mon, 14 Mar 2011 17:48:26 -0300 From: Luiz Capitulino Subject: Re: [Qemu-devel] Re: [PATCH 02/11] qerror: expose a function to format an error Message-ID: <20110314174826.6c9a90f3@doriath> In-Reply-To: <4D7E7D8D.8040300@us.ibm.com> References: <1299877249-13433-1-git-send-email-aliguori@us.ibm.com> <1299877249-13433-3-git-send-email-aliguori@us.ibm.com> <4D7A8F56.2080703@us.ibm.com> <20110314161728.36c3ca7e@doriath> <4D7E6C22.8010102@codemonkey.ws> <20110314163747.77392d06@doriath> <4D7E7049.10304@us.ibm.com> <20110314172207.15587e00@doriath> <4D7E7D8D.8040300@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Paolo Bonzini , Michael@gnu.org, qemu-devel@nongnu.org, Roth , Markus Armbruster On Mon, 14 Mar 2011 15:41:49 -0500 Anthony Liguori wrote: > On 03/14/2011 03:22 PM, Luiz Capitulino wrote: > > On Mon, 14 Mar 2011 14:45:13 -0500 > > Anthony Liguori wrote: > > > >> On 03/14/2011 02:37 PM, Luiz Capitulino wrote: > >>> qerror_abort() only exists for debugging purposes. I won't say its perfect, > >>> but it's better than nothing and has already saved some time when writing > >>> new errors. > >>> > >>> I'm fine dropping it as long as there's a better replacement, which is > >>> not the case here. There's even a hunk that replaces qerror_abort() for > >>> a plain abort(). > >> Yes, that's the replacement. > > It's not a good one: it makes the current code a bit worse and we don't know > > how and when the error classes are going to be replaced. > > Yes, we do, before 0.15.0. Very optimistic :) I don't doubt you can post patches quickly, but we're likely going to have fun discussions, respins, tests etc. And all the QAPI stuff in parallel. > > Maybe a better merge plan would be to work on errors first. Completely drop > > qerror according to qapi needs, and then put the rest of the stuff on top. > > Can't be done until we introduce new QMP commands to get rid of the old > HMP commands because there are HMP commands without equivalents that > make use of qerror_report(). > > There are just a handful of these left in my QAPI branch so once I can > start adding these QMP commands, they'll be gone quickly. I don't want > to introduce a bunch of new QMP commands without this stuff getting > merged upstream first though. > > Regards, > > Anthony Liguori >