From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48571 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PzWA3-0004p2-Bl
	for qemu-devel@nongnu.org; Tue, 15 Mar 2011 11:27:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arun@linux.vnet.ibm.com>) id 1PzWA2-0003fE-7q
	for qemu-devel@nongnu.org; Tue, 15 Mar 2011 11:27:51 -0400
Received: from e28smtp04.in.ibm.com ([122.248.162.4]:56543)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arun@linux.vnet.ibm.com>) id 1PzWA1-0003dW-IY
	for qemu-devel@nongnu.org; Tue, 15 Mar 2011 11:27:50 -0400
Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58])
	by e28smtp04.in.ibm.com (8.14.4/8.13.1) with ESMTP id p2FFRhCr008980
	for <qemu-devel@nongnu.org>; Tue, 15 Mar 2011 20:57:43 +0530
Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66])
	by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p2FFRhUv3883146
	for <qemu-devel@nongnu.org>; Tue, 15 Mar 2011 20:57:43 +0530
Received: from d28av04.in.ibm.com (loopback [127.0.0.1])
	by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p2FFRgKe027317
	for <qemu-devel@nongnu.org>; Wed, 16 Mar 2011 02:27:42 +1100
Date: Tue, 15 Mar 2011 20:57:38 +0530
From: Arun R Bharadwaj <arun@linux.vnet.ibm.com>
Message-ID: <20110315152738.GA26146@linux.vnet.ibm.com>
References: <20110315103453.GA23922@linux.vnet.ibm.com>
	<20110315103626.GB23922@linux.vnet.ibm.com>
	<AANLkTi=kX782NVRChgZ3kw3foNy4fwqq-yx39LWW3zY-@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <AANLkTi=kX782NVRChgZ3kw3foNy4fwqq-yx39LWW3zY-@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [v1 PATCH 1/3]: Move the paio_signal_handler to a
 generic location.
Reply-To: arun@linux.vnet.ibm.com
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: aliguori@us.ibm.com, jvrao@linux.vnet.ibm.com, qemu-devel@nongnu.org, aneesh.kumar@linux.vnet.ibm.com

* Stefan Hajnoczi <stefanha@gmail.com> [2011-03-15 11:38:03]:

> On Tue, Mar 15, 2011 at 10:36 AM, Arun R Bharadwaj
> <arun@linux.vnet.ibm.com> wrote:
> > * Arun R Bharadwaj <arun@linux.vnet.ibm.com> [2011-03-15 16:04:53]:
> >
> > Author: Arun R Bharadwaj <arun@linux.vnet.ibm.com>
> > Date: =A0 Thu Mar 10 14:45:25 2011 +0530
> >
> > =A0 =A0Move the paio_signal_handler to a generic location.
> >
> > =A0 =A0The paio subsystem uses the signal, SIGUSR2. So move
> > =A0 =A0the signal handler to a more generic place such that
> > =A0 =A0other subsystems like 9pfs can also use it.
> >
> > =A0 =A0TODO: I have moved the signal handler code to
> > =A0 =A0qemu-thread.c, which is NOT the right place. I need
> > =A0 =A0suggestions as to where is the right place to put it.
>=20
> I think os-posix.c would be appropriate.  Please check how this
> affects Windows host and linux-user builds.
>=20

Anthony's reply negates this point. I will remove the signalling code
and also check the behaviour of Windows host and linux-user builds.

> > @@ -356,6 +359,15 @@ static void *aio_thread(void *unused)
> > =A0 =A0 =A0 =A0 idle_threads++;
> > =A0 =A0 =A0 =A0 mutex_unlock(&lock);
> >
> > + =A0 =A0 =A0 =A0if (posix_aio_state) {
>=20
> If we get here posix_aio_state must be non-NULL.  Please remove the che=
ck.
>=20

Yes, will remove this.

> > +void sigusr2_signal_handler(int signum)
>=20
> static void sigusr2_signal_handler(int signum)
>=20

Thanks for noticing this.

> Stefan