From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47151 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzZZQ-0006dH-WB for qemu-devel@nongnu.org; Tue, 15 Mar 2011 15:06:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzZZP-0003aA-K0 for qemu-devel@nongnu.org; Tue, 15 Mar 2011 15:06:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzZZP-0003a4-82 for qemu-devel@nongnu.org; Tue, 15 Mar 2011 15:06:15 -0400 Date: Tue, 15 Mar 2011 12:06:06 -0700 From: Chris Wright Subject: Re: [Qemu-devel] KVM call minutes for Mar 15 Message-ID: <20110315190606.GM20456@x200.localdomain> References: <20110315145346.GH20456@x200.localdomain> <4D7F93AB.4050207@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D7F93AB.4050207@codemonkey.ws> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Chris Wright , kvm@vger.kernel.org, libvir-list@redhat.com, qemu-devel@nongnu.org, Chris Lalancette , Jiri Denemark * Anthony Liguori (anthony@codemonkey.ws) wrote: > On 03/15/2011 09:53 AM, Chris Wright wrote: > > QAPI > >- c library implementation is critical to have unit tests and test > > driven development > > - thread safe? > > - no shared state, no statics. > > - threading model requires lock for the qmp session > > - licensiing? > > - LGPL > > - forwards/backwards compat? > > - designed with that in mind see wiki: > > > > http://wiki.qemu.org/Features/QAPI > > One neat feature of libqmp is that once libvirt has a better QMP > passthrough interface, we can create a QmpSession that uses libvirt. > > It would look something like: > > QmpSession *libqmp_session_new_libvirt(virDomainPtr dom); Looks like you mean this? -> request QmpSession -> client libvirt <- return QmpSession <- client -> QmpSession -> QMP -> QEMU So bypassing libvirt completely to actually use the session? Currently, it's more like: client -> QemuMonitorCommand -> libvirt -> QMP -> QEMU > The QmpSession returned by this call can then be used with all of > the libqmp interfaces. This means we can still exercise our test > suite with a guest launched through libvirt. It also should make > the libvirt pass through interface a bit easier to consume by third > parties. This sounds like it's something libvirt folks should be involved with. At the very least, this mode is there now and considered basically unstable/experimental/developer use: "Qemu monitor command '%s' executed; libvirt results may be unpredictable!" So likely some concern about making it easier to use, esp. assuming that third parties above are mgmt apps, not just developers. thanks, -chris