From: Christoph Hellwig <hch@lst.de>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com,
"prerna@linux.vnet.ibm.com Anthony Liguori" <aliguori@us.ibm.com>,
Christoph Hellwig <hch@lst.de>,
qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 1/4] block: clarify the meaning of BDRV_O_NOCACHE
Date: Wed, 16 Mar 2011 15:08:44 +0100 [thread overview]
Message-ID: <20110316140844.GA21877@lst.de> (raw)
In-Reply-To: <AANLkTikGa2o-qso-kGWUkh4qN8gtkr6K=p_k1zJe3s48@mail.gmail.com>
On Wed, Mar 16, 2011 at 09:42:37AM +0000, Stefan Hajnoczi wrote:
> - writethrough = ((flags & BDRV_O_CACHE_MASK) == 0);
> + writethrough = ((flags & (BDRV_O_CACHE_WB | BDRV_O_NO_FLUSH)) == 0);
or rather
writethrough = ((flags & (BDRV_O_CACHE_WB) != );
but yes, this code had sneaked in since my initial version.
next prev parent reply other threads:[~2011-03-16 14:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 14:10 [Qemu-devel] [PATCH, RFC 0/4] allow guest control of the volatile write cache Christoph Hellwig
2011-03-15 14:11 ` [Qemu-devel] [PATCH 1/4] block: clarify the meaning of BDRV_O_NOCACHE Christoph Hellwig
2011-03-16 9:42 ` [Qemu-devel] " Stefan Hajnoczi
2011-03-16 9:55 ` Kevin Wolf
2011-03-16 14:08 ` Christoph Hellwig [this message]
2011-03-16 17:00 ` Stefan Hajnoczi
2011-03-17 9:07 ` Kevin Wolf
2011-03-17 9:18 ` Stefan Hajnoczi
2011-03-15 14:11 ` [Qemu-devel] [PATCH 2/4] block: add a helper to change writeback mode on the fly Christoph Hellwig
2011-03-15 14:11 ` [Qemu-devel] [PATCH 3/4] ide: wire up setfeatures cache control Christoph Hellwig
2011-03-15 14:11 ` [Qemu-devel] [PATCH 4/4] virtio-blk: add runtime " Christoph Hellwig
2011-03-16 9:49 ` [Qemu-devel] Re: [PATCH 2/4] block: add a helper to change writeback mode on the fly Stefan Hajnoczi
2011-03-16 9:59 ` Kevin Wolf
2011-03-17 14:44 ` [Qemu-devel] " Daniel P. Berrange
2011-03-17 15:11 ` Kevin Wolf
2011-03-17 16:44 ` Stefan Hajnoczi
2011-03-19 8:28 ` Blue Swirl
2011-03-15 14:16 ` [Qemu-devel] [PATCH, RFC] virtio_blk: add cache control support Christoph Hellwig
2011-03-16 4:09 ` [Qemu-devel] " Rusty Russell
2011-03-16 14:09 ` Christoph Hellwig
2011-03-17 5:06 ` Rusty Russell
2011-03-17 14:21 ` Christoph Hellwig
2011-03-24 0:11 ` Rusty Russell
2011-03-24 3:11 ` Anthony Liguori
2011-03-24 3:05 ` Anthony Liguori
2011-03-24 9:54 ` Christian Borntraeger
2011-03-25 5:08 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110316140844.GA21877@lst.de \
--to=hch@lst.de \
--cc=aliguori@us.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).