From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46440 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PzrPB-0007zg-Uz
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 10:08:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hch@lst.de>) id 1PzrP4-0001io-DT
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 10:08:47 -0400
Received: from verein.lst.de ([213.95.11.211]:49323 helo=newverein.lst.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1PzrP4-0001id-8c
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 10:08:46 -0400
Date: Wed, 16 Mar 2011 15:08:44 +0100
From: Christoph Hellwig <hch@lst.de>
Message-ID: <20110316140844.GA21877@lst.de>
References: <20110315141049.GA30627@lst.de> <20110315141100.GA30710@lst.de>
	<AANLkTikGa2o-qso-kGWUkh4qN8gtkr6K=p_k1zJe3s48@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTikGa2o-qso-kGWUkh4qN8gtkr6K=p_k1zJe3s48@mail.gmail.com>
Subject: [Qemu-devel] Re: [PATCH 1/4] block: clarify the meaning of
	BDRV_O_NOCACHE
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, "prerna@linux.vnet.ibm.com Anthony Liguori" <aliguori@us.ibm.com>, Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

On Wed, Mar 16, 2011 at 09:42:37AM +0000, Stefan Hajnoczi wrote:
> -    writethrough = ((flags & BDRV_O_CACHE_MASK) == 0);
> +    writethrough = ((flags & (BDRV_O_CACHE_WB | BDRV_O_NO_FLUSH)) == 0);

or rather

	writethrough = ((flags & (BDRV_O_CACHE_WB) != );

but yes, this code had sneaked in since my initial version.