From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35183 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzyMq-0007ff-35 for qemu-devel@nongnu.org; Wed, 16 Mar 2011 17:34:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzyMo-0004cN-LQ for qemu-devel@nongnu.org; Wed, 16 Mar 2011 17:34:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzyMo-0004cJ-Bt for qemu-devel@nongnu.org; Wed, 16 Mar 2011 17:34:54 -0400 Date: Wed, 16 Mar 2011 23:34:42 +0200 From: "Michael S. Tsirkin" Message-ID: <20110316213441.GA32049@redhat.com> References: <392c8eaaeb8f0729ab39b261d0dda21208c05ea6.1300266238.git.yamahata@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <392c8eaaeb8f0729ab39b261d0dda21208c05ea6.1300266238.git.yamahata@valinux.co.jp> Subject: [Qemu-devel] Re: [PATCH 07/26] pci/p2pbr: generic pci p2p bridge List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: qemu-devel@nongnu.org On Wed, Mar 16, 2011 at 06:29:18PM +0900, Isaku Yamahata wrote: > Create generic pci p2p bridge device which can be customized > via properties like vendor id/device id and so on. > With this, we can avoid to create many pci p2p bridge which only > differs in those ids. > > Cc: Michael S. Tsirkin > Signed-off-by: Isaku Yamahata So we added 213 lines and we saved all of 20 in other places? Maybe I miss the point ... > --- > Makefile.objs | 2 +- > hw/pci_p2pbr.c | 151 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > hw/pci_p2pbr.h | 61 +++++++++++++++++++++++ > 3 files changed, 213 insertions(+), 1 deletions(-) > create mode 100644 hw/pci_p2pbr.c > create mode 100644 hw/pci_p2pbr.h