From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47856 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q0316-0004Ev-N4 for qemu-devel@nongnu.org; Wed, 16 Mar 2011 22:32:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q0315-0003Mb-Ip for qemu-devel@nongnu.org; Wed, 16 Mar 2011 22:32:48 -0400 Received: from ozlabs.org ([203.10.76.45]:45150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q0315-0003M9-7I for qemu-devel@nongnu.org; Wed, 16 Mar 2011 22:32:47 -0400 Date: Thu, 17 Mar 2011 12:29:30 +1100 From: David Gibson Message-ID: <20110317012930.GC1105@yookeroo> References: <1300251423-6715-1-git-send-email-david@gibson.dropbear.id.au> <1300251423-6715-19-git-send-email-david@gibson.dropbear.id.au> <4D80DB7F.2040103@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D80DB7F.2040103@suse.de> Subject: [Qemu-devel] Re: [PATCH 18/26] Implement the PAPR (pSeries) virtualized interrupt controller (xics) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: paulus@samba.org, qemu-devel@nongnu.org, anton@samba.org On Wed, Mar 16, 2011 at 04:47:11PM +0100, Alexander Graf wrote: > On 03/16/2011 05:56 AM, David Gibson wrote: [snip] > >+/* static void ics_resend(struct icp_server_state *ss) */ > >+/* { */ > >+/* int i; */ > >+ > >+/* for (i = 0; i< xics->nr_irqs; i++) */ > >+/* ics_resend_irq(xics, nr, ss); */ > >+/* } */ > > Why is all this commented out? Better #if 0 it all away. Or even > better, don't include it in the patch - unless you think the code is > crucial and to be activated soon. Hrm, it was supposed to implement level (rather than message) interrupts on XICS. But I think its bitrotted since I commented it out. Removed. > >diff --git a/hw/xics.h b/hw/xics.h > >new file mode 100644 > >index 0000000..e55f5f1 > >--- /dev/null > >+++ b/hw/xics.h > > Header missing I'm not sure what you mean by this -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson