From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47896 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q0318-0004HQ-7W
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 22:32:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1Q0317-0003NN-5c
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 22:32:50 -0400
Received: from ozlabs.org ([203.10.76.45]:45157)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1Q0316-0003Mw-Ka
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 22:32:49 -0400
Date: Thu, 17 Mar 2011 12:34:59 +1100
From: David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH 18/26] Implement the PAPR (pSeries)
	virtualized interrupt controller (xics)
Message-ID: <20110317013459.GD1105@yookeroo>
References: <1300251423-6715-1-git-send-email-david@gibson.dropbear.id.au>
	<1300251423-6715-19-git-send-email-david@gibson.dropbear.id.au>
	<4D8136A7.2040706@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D8136A7.2040706@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: paulus@samba.org, agraf@suse.de, anton@samba.org, qemu-devel@nongnu.org

On Wed, Mar 16, 2011 at 05:16:07PM -0500, Anthony Liguori wrote:
> On 03/15/2011 11:56 PM, David Gibson wrote:
[snip]
> >+#include<pthread.h>
> 
> This isn't needed and it'll break the Windows build.   We carry a
> global mutex whenever QEMU code executes.

Good point, I wrote this before I realized all the qemu code was serialized.

> >+/*
> >+ * ICP: Presentation layer
> >+ */
> >+
> >+struct icp_server_state {
> >+    uint32_t cppr :8;
> >+    uint32_t xisr :24;
> 
> No real reason to use bitfields here.

Well.. in the hardware xics implementation, CPPR and XISR are
considered fields of the one 32-bit register, XIRR.  Matching that is
why I have the bitfield.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson