From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47900 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q0318-0004Hc-8n for qemu-devel@nongnu.org; Wed, 16 Mar 2011 22:32:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q0317-0003NS-5q for qemu-devel@nongnu.org; Wed, 16 Mar 2011 22:32:50 -0400 Received: from ozlabs.org ([203.10.76.45]:45158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q0316-0003Mv-Kf for qemu-devel@nongnu.org; Wed, 16 Mar 2011 22:32:49 -0400 Date: Thu, 17 Mar 2011 12:38:39 +1100 From: David Gibson Message-ID: <20110317013839.GE1105@yookeroo> References: <1300251423-6715-1-git-send-email-david@gibson.dropbear.id.au> <1300251423-6715-20-git-send-email-david@gibson.dropbear.id.au> <4D80DBF3.4000400@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D80DBF3.4000400@suse.de> Subject: [Qemu-devel] Re: [PATCH 19/26] Add PAPR H_VIO_SIGNAL hypercall and infrastructure for VIO interrupts List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: paulus@samba.org, qemu-devel@nongnu.org, anton@samba.org On Wed, Mar 16, 2011 at 04:49:07PM +0100, Alexander Graf wrote: > On 03/16/2011 05:56 AM, David Gibson wrote: [snip] > >+ return H_PARAMETER;; > >+ > >+ dev->signal_state = mode; > > No need to notify the device? No, at the point it would send an interrupt the device checks signal_state. That said, I was considering another cleanup to the signal code to have the devices use a helper function checking signal_state, and also allowing multiple interrupts for a VIO device. Not sure if it's worth folding that into this series or doing it as a later extension. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson