From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47933 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q0319-0004Ib-5T
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 22:32:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1Q0318-0003O6-1o
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 22:32:51 -0400
Received: from ozlabs.org ([203.10.76.45]:45158)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1Q0317-0003Mv-Mm
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 22:32:49 -0400
Date: Thu, 17 Mar 2011 13:04:27 +1100
From: David Gibson <david@gibson.dropbear.id.au>
Message-ID: <20110317020427.GG1105@yookeroo>
References: <1300251423-6715-1-git-send-email-david@gibson.dropbear.id.au>
	<1300251423-6715-23-git-send-email-david@gibson.dropbear.id.au>
	<4D80E161.5080704@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D80E161.5080704@suse.de>
Subject: [Qemu-devel] Re: [PATCH 22/26] Implement sPAPR Virtual LAN (ibmveth)
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: paulus@samba.org, qemu-devel@nongnu.org, anton@samba.org

On Wed, Mar 16, 2011 at 05:12:17PM +0100, Alexander Graf wrote:
> On 03/16/2011 05:56 AM, David Gibson wrote:
[snip]
> >+#include "hw.h"
> >+#include "net.h"
> >+#include "hw/qdev.h"
> >+#include "hw/spapr.h"
> >+#include "hw/spapr_vio.h"
> >+
> >+#include<libfdt.h>
> 
> Hrm - might be good to protect compilation against existence of fdt
> then?

Ah, yeah, you've reminded me.  So this appears in a number of places.
We basically have to have fdt support for the pseries platform.
What's the right way to make the whole machine definition conditional
upon libfdt?

Incidentally, can I suggest it might be a good idea to include libfdt
in the qemu tree and make it always-on instead of configurable.

[snip]
> >+    lbuf = qemu_mallocz(total_len);
> 
> Do you really need the zeroing here? In fact, this looks like a good
> candidate for alloca :).

Ah, good idea.

[snip]
> >-#define SPAPR_VIO_TCE_PAGE_SHIFT	12
> >-#define SPAPR_VIO_TCE_PAGE_SIZE		(1ULL<<  SPAPR_VIO_TCE_PAGE_SHIFT)
> >-#define SPAPR_VIO_TCE_PAGE_MASK		(SPAPR_VIO_TCE_PAGE_SIZE - 1)
> >+#define SPAPR_VIO_TCE_PAGE_SHIFT   12
> >+#define SPAPR_VIO_TCE_PAGE_SIZE    (1ULL<<  SPAPR_VIO_TCE_PAGE_SHIFT)
> >+#define SPAPR_VIO_TCE_PAGE_MASK    (SPAPR_VIO_TCE_PAGE_SIZE - 1)
> 
> Those shouldn't have been tabs in the first place :)

Fixed in the original patch now.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson