From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52621 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q05ny-0005Hz-Fk for qemu-devel@nongnu.org; Thu, 17 Mar 2011 01:31:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q05nx-0007bB-5M for qemu-devel@nongnu.org; Thu, 17 Mar 2011 01:31:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q05nw-0007b4-SB for qemu-devel@nongnu.org; Thu, 17 Mar 2011 01:31:25 -0400 Date: Thu, 17 Mar 2011 07:31:13 +0200 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] Re: [PATCH 07/26] pci/p2pbr: generic pci p2p bridge Message-ID: <20110317053113.GG32049@redhat.com> References: <392c8eaaeb8f0729ab39b261d0dda21208c05ea6.1300266238.git.yamahata@valinux.co.jp> <20110316213441.GA32049@redhat.com> <20110317020851.GG16841@valinux.co.jp> <20110317051718.GE32049@redhat.com> <20110317052624.GJ16841@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110317052624.GJ16841@valinux.co.jp> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: qemu-devel@nongnu.org On Thu, Mar 17, 2011 at 02:26:24PM +0900, Isaku Yamahata wrote: > On Thu, Mar 17, 2011 at 07:17:18AM +0200, Michael S. Tsirkin wrote: > > > Anyway this patch isn't very critical. I think the available choice is > > > > > > - this patch > > > - modify the patch to use 14 arguments function. > > > Thus we can save much more lines. > > > - Add one more p2p bridge code which q35 uses, accepting same code which > > > differs only in IDs. > > > - any other ideas? > > > > > > Which option do you prefer? > > > > Add one more bridge for q35. > > Okay. > How about other pci related patches? I think they are trivial. I'll look at the usage to see how good new APIs are. > -- > yamahata