From: Isaku Yamahata <yamahata@valinux.co.jp>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 3/3] piix_pci: optimize set irq path
Date: Fri, 18 Mar 2011 07:56:44 +0900 [thread overview]
Message-ID: <20110317225644.GC14147@valinux.co.jp> (raw)
In-Reply-To: <20110317144108.GA22213@redhat.com>
On Thu, Mar 17, 2011 at 04:41:08PM +0200, Michael S. Tsirkin wrote:
> > +static int piix3_post_load(void *opaque, int version_id)
> > +{
> > + PIIX3State *piix3 = opaque;
> > + piix3_rebuild_irq_levels(piix3);
>
> Don't we need to set_irq_pic here as well?
> And in that case, just make the for loop
> part of piix3_rebuild_irq_levels.
No, we need not. Because pic irq state is saved/loaded by pic itself.
So todo here is to make pic_levels consistent with other part.
--
yamahata
next prev parent reply other threads:[~2011-03-17 22:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 13:49 [Qemu-devel] [PATCH 0/3] piix_pci: optimize irq data path Isaku Yamahata
2011-03-17 13:49 ` [Qemu-devel] [PATCH 1/3] pci: add accessor function to get irq levels Isaku Yamahata
2011-03-17 13:49 ` [Qemu-devel] [PATCH 2/3] piix_pci: eliminate PIIX3State::pci_irq_levels Isaku Yamahata
2011-03-17 13:49 ` [Qemu-devel] [PATCH 3/3] piix_pci: optimize set irq path Isaku Yamahata
2011-03-17 14:41 ` [Qemu-devel] " Michael S. Tsirkin
2011-03-17 22:56 ` Isaku Yamahata [this message]
2011-03-17 14:42 ` [Qemu-devel] Re: [PATCH 0/3] piix_pci: optimize irq data path Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110317225644.GC14147@valinux.co.jp \
--to=yamahata@valinux.co.jp \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).