From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48372 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q0Y1a-0001Gl-Cm
	for qemu-devel@nongnu.org; Fri, 18 Mar 2011 07:39:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1Q0Y1Y-0006Nf-SN
	for qemu-devel@nongnu.org; Fri, 18 Mar 2011 07:39:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15476)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1Q0Y1Y-0006NK-Jy
	for qemu-devel@nongnu.org; Fri, 18 Mar 2011 07:39:20 -0400
Date: Fri, 18 Mar 2011 08:29:11 -0300
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20110318112911.GA2436@amt.cnet>
References: <cover.1300188374.git.jan.kiszka@siemens.com>
	<b8c5dfe9505a48556ee17545a53e8f6245e4b262.1300188374.git.jan.kiszka@siemens.com>
	<20110315171011.GA25624@amt.cnet> <4D7FC84B.70906@web.de>
	<4D833180.5020603@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D833180.5020603@web.de>
Subject: [Qemu-devel] Re: [PATCH v2 06/20] kvm: Install optimized interrupt
	handler
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org

On Fri, Mar 18, 2011 at 11:18:40AM +0100, Jan Kiszka wrote:
> On 2011-03-15 21:12, Jan Kiszka wrote:
> > On 2011-03-15 18:10, Marcelo Tosatti wrote:
> >> On Tue, Mar 15, 2011 at 12:26:17PM +0100, Jan Kiszka wrote:
> >>> KVM only requires to set the raised IRQ in CPUState and to kick the
> >>> receiving vcpu if it is remote.
> >>>
> >>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >>> ---
> >>>  kvm-all.c |   11 +++++++++++
> >>>  1 files changed, 11 insertions(+), 0 deletions(-)
> >>>
> >>> diff --git a/kvm-all.c b/kvm-all.c
> >>> index 226843c..25ab545 100644
> >>> --- a/kvm-all.c
> >>> +++ b/kvm-all.c
> >>> @@ -650,6 +650,15 @@ static CPUPhysMemoryClient kvm_cpu_phys_memory_client = {
> >>>      .log_stop = kvm_log_stop,
> >>>  };
> >>>  
> >>> +static void kvm_handle_interrupt(CPUState *env, int mask)
> >>> +{
> >>> +    env->interrupt_request |= mask;
> >>> +
> >>> +    if (!qemu_cpu_is_self(env)) {
> >>> +        qemu_cpu_kick(env);
> >>> +    }
> >>> +}
> >>> +
> >>
> >> Not sure its worthwhile to allow different handlers. The advantage over
> >> tcg version is that its shorter, without cpu_unlink_tb and icount
> >> handler?
> > 
> > I thought about this again as well before posting, and I came to the
> > conclusion that an important advantage is avoiding TCG surprises in KVM
> > code paths. This way, KVM does not need to bother if cpu_unlink_tb or
> > icount related code changes. Maybe I should have added this to the
> > commit message.
> 
> What's your opinion on this? Should I repost the remaining three with
> comments adjusted?
> 
> Jan
>

Its up to you. Your argument above makes sense.